dlmarion commented on code in PR #6486:
URL: https://github.com/apache/accumulo/pull/6486#discussion_r3629866427
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/CompactionWatcher.java:
##########
@@ -121,11 +122,14 @@ public void run() {
}
}
- public static synchronized void startWatching(ServerContext context) {
- if (!watching) {
-
ThreadPools.watchCriticalScheduledTask(context.getScheduledExecutor().scheduleWithFixedDelay(
- new CompactionWatcher(context.getConfiguration()), 10000, 10000,
TimeUnit.MILLISECONDS));
- watching = true;
+ public static void startWatching(ServerContext context) {
Review Comment:
Does the exclusion not cover this case? Just curious why we are fixing some
of these but also have the exclusion.
##########
server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthenticator.java:
##########
@@ -88,7 +89,7 @@ public void initializeSecurity(String principal, byte[]
token) {
try {
// remove old settings from zookeeper first, if any
ZooReaderWriter zoo = context.getZooReaderWriter();
- synchronized (zooCache) {
+ synchronized (zooCacheLock) {
Review Comment:
Why did this have to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
