Author: jkf Date: Sat Jan 31 16:26:41 2009 New Revision: 739575 URL: http://svn.apache.org/viewvc?rev=739575&view=rev Log: Math.abs(rand.nextInt()) may yield negative value. rand.nextInt(Integer.MAX_VALUE) seems to be what was meant.
Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java?rev=739575&r1=739574&r2=739575&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java Sat Jan 31 16:26:41 2009 @@ -891,7 +891,7 @@ synchronized (rand) { do { result = new File(parent, prefix - + fmt.format(Math.abs(rand.nextInt())) + suffix); + + fmt.format(rand.nextInt(Integer.MAX_VALUE)) + suffix); } while (result.exists()); } }