https://issues.apache.org/bugzilla/show_bug.cgi?id=47373
--- Comment #12 from Jesse Glick <[email protected]> 2009-06-19 12:57:49 PST --- I will do my best to review proposed patches, and it looks like Stefan will as well. I think "contentdate" (or "entrydate"?) is more likely to be understood immediately. "lastmodified" to me might sound like it has something to do with the timestamp of the ZIP file itself - perhaps affecting the up-to-date check. For consistency I would recommend using the same date syntax as <touch> uses: a string parsed according to DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.MEDIUM, Locale.US) with the option to select a different "pattern" a la SimpleDateFormat. Relying on the current locale for anything seems like a bad idea to me; build scripts should run the same on anyone's computer. It occurs to me that putting this new attribute on the task is wrong. Rather, it should be on the <zipfileset>, i.e. ArchiveFileSet generally. (Compare existing idiom for setting file mode.) If using the 'src' attr, ArchiveScanner could be given a 'long timestamp' property, which would be passed along to each ArchiveResource. If using the 'dir' attr, I presume this would also work somehow, though I have not yet figured out how since AFS seems to just call super.getDirectoryScanner and I don't see where mode & prefix are used when src == null. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
