Author: bodewig
Date: Fri Aug 21 04:30:23 2009
New Revision: 806417
URL: http://svn.apache.org/viewvc?rev=806417&view=rev
Log:
we really should not invoke virtual methods inside constructors, must be fixed
Modified:
ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/resources/TarResource.java
ant/sandbox/antlibs/compress/trunk/src/tests/antunit/tar-test.xml
ant/sandbox/antlibs/compress/trunk/src/tests/antunit/zip-test.xml
Modified:
ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/resources/TarResource.java
URL:
http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/resources/TarResource.java?rev=806417&r1=806416&r2=806417&view=diff
==============================================================================
---
ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/resources/TarResource.java
(original)
+++
ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/resources/TarResource.java
Fri Aug 21 04:30:23 2009
@@ -47,6 +47,7 @@
*/
public TarResource(File a, TarArchiveEntry e) {
super(new TarStreamFactory(), "tar", a, e);
+ setEntry(e);
}
/**
@@ -57,6 +58,7 @@
*/
public TarResource(Resource a, TarArchiveEntry e) {
super(new TarStreamFactory(), "tar", a, e);
+ setEntry(e);
}
/**
Modified: ant/sandbox/antlibs/compress/trunk/src/tests/antunit/tar-test.xml
URL:
http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/tests/antunit/tar-test.xml?rev=806417&r1=806416&r2=806417&view=diff
==============================================================================
--- ant/sandbox/antlibs/compress/trunk/src/tests/antunit/tar-test.xml (original)
+++ ant/sandbox/antlibs/compress/trunk/src/tests/antunit/tar-test.xml Fri Aug
21 04:30:23 2009
@@ -117,14 +117,14 @@
uid="500" gid="500" user="bodewig" group="bodewig"/>
</target>
- <!--target name="testAntlibTarFileSet" depends="setUp">
+ <target name="testAntlibTarFileSet" depends="setUp">
<cmp:tar destfile="${dest}">
<cmp:tarfileset src="../resources/asf-logo.gif.tar"
includes="asf-logo.gif"/>
</cmp:tar>
<checkProperties dateTime="2001-11-19-15:34:20 +0100" mode="33188"
uid="500" gid="500" user="bodewig" group="bodewig"/>
- </target-->
+ </target>
<target name="testArFileSet" depends="setUp">
<cmp:tar destfile="${dest}">
Modified: ant/sandbox/antlibs/compress/trunk/src/tests/antunit/zip-test.xml
URL:
http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/tests/antunit/zip-test.xml?rev=806417&r1=806416&r2=806417&view=diff
==============================================================================
--- ant/sandbox/antlibs/compress/trunk/src/tests/antunit/zip-test.xml (original)
+++ ant/sandbox/antlibs/compress/trunk/src/tests/antunit/zip-test.xml Fri Aug
21 04:30:23 2009
@@ -27,7 +27,6 @@
<property name="dest" location="${output}/test.zip"/>
<macrodef name="checkProperties">
<attribute name="dateTime"/>
- <!-- FIXME -->
<attribute name="mode" default="33188"/>
<sequential>
<au:assertTrue>
