https://bz.apache.org/bugzilla/show_bug.cgi?id=43271

--- Comment #4 from Stefan Bodewig <[email protected]> ---
Thanks a lot for the patch, some comments:

* please don't use protected fields.  There are some inside Ant's code base but
they are only kept for backwards compatibility reasons.

* usually "umask" applies to directories and files.  Your patch uses "umask"
for directories and "chmod" for files.  This is confusing.  Maybe it would be
better to go with the already existing names of "dirmode" and "mode" like we
are using for <zipfileset>?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to