<get>'s quiet attribute is broken

https://bz.apache.org/bugzilla/show_bug.cgi?id=59379


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/647bdfb2
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/647bdfb2
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/647bdfb2

Branch: refs/heads/1.9.x
Commit: 647bdfb2d72ba111d9c6944351bd8b9392056b05
Parents: 434193d
Author: Stefan Bodewig <[email protected]>
Authored: Sun May 1 06:41:11 2016 +0200
Committer: Stefan Bodewig <[email protected]>
Committed: Sun May 1 06:41:11 2016 +0200

----------------------------------------------------------------------
 WHATSNEW                                        | 3 +++
 src/main/org/apache/tools/ant/taskdefs/Get.java | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/647bdfb2/WHATSNEW
----------------------------------------------------------------------
diff --git a/WHATSNEW b/WHATSNEW
index 681b5cf..68338fc 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -12,6 +12,9 @@ Fixed bugs:
    they have specified.
    Bugzilla Report 59339
 
+ * <get>'s quiet attribute was broken, it didn't suppress any messages.
+   Bugzilla Report 59379
+
 Other changes:
 --------------
 

http://git-wip-us.apache.org/repos/asf/ant/blob/647bdfb2/src/main/org/apache/tools/ant/taskdefs/Get.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/Get.java 
b/src/main/org/apache/tools/ant/taskdefs/Get.java
index 5ff9a54..6c53790 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Get.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Get.java
@@ -259,7 +259,7 @@ public class Get extends Task {
 
     @Override
     public void log(final String msg, final int msgLevel) {
-        if (!quiet || msgLevel >= Project.MSG_ERR) {
+        if (!quiet || msgLevel <= Project.MSG_ERR) {
             super.log(msg, msgLevel);
         }
     }

Reply via email to