Sonar falsely claims expressions to be constant
Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/eaf3af0a Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/eaf3af0a Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/eaf3af0a Branch: refs/heads/1.9.x Commit: eaf3af0aea8b14c4a5d8d63bc4cb22f88dbb19a4 Parents: 144fc49 Author: Stefan Bodewig <[email protected]> Authored: Wed Dec 21 11:22:00 2016 +0100 Committer: Stefan Bodewig <[email protected]> Committed: Wed Dec 21 11:22:00 2016 +0100 ---------------------------------------------------------------------- src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java | 2 +- src/main/org/apache/tools/ant/taskdefs/StreamPumper.java | 2 +- src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java | 2 +- .../org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java | 2 +- src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ant/blob/eaf3af0a/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java b/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java index ae95c3b..0c7c35b 100644 --- a/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java +++ b/src/main/org/apache/tools/ant/ArgumentProcessorRegistry.java @@ -84,7 +84,7 @@ public class ArgumentProcessorRegistry { } InputStream systemResource = ClassLoader.getSystemResourceAsStream(SERVICE_ID); - if (systemResource != null) { + if (systemResource != null) { //NOSONAR ArgumentProcessor processor = getProcessorByService(systemResource); registerArgumentProcessor(processor); } http://git-wip-us.apache.org/repos/asf/ant/blob/eaf3af0a/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java b/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java index df95eed..59d886b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java +++ b/src/main/org/apache/tools/ant/taskdefs/StreamPumper.java @@ -137,7 +137,7 @@ public class StreamPumper implements Runnable { if (autoflush) { os.flush(); } - if (finish) { + if (finish) { //NOSONAR break; } } http://git-wip-us.apache.org/repos/asf/ant/blob/eaf3af0a/src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java index 61d6e3d..d88874f 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/RExecTask.java @@ -362,7 +362,7 @@ public class RExecTask extends Task { } catch (IOException e) { throw new BuildException("Can't connect to " + server); } - if (userid != null && password != null && command != null + if (userid != null && password != null && command != null //NOSONAR && rexecTasks.size() == 0) { // simple one-shot execution rexec.rexec(userid, password, command); http://git-wip-us.apache.org/repos/asf/ant/blob/eaf3af0a/src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java index 2bd2205..a89e7a9 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.java @@ -107,7 +107,7 @@ public class TelnetTask extends Task { throw new BuildException("Can't connect to " + server); } /** Login if userid and password were specified */ - if (userid != null && password != null) { + if (userid != null && password != null) { //NOSONAR login(telnet); } /** Process each sub command */ http://git-wip-us.apache.org/repos/asf/ant/blob/eaf3af0a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java index d2a09bc..087a402 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java @@ -267,7 +267,7 @@ public class Scp extends SSHBase { } else { upload(fromUri, toUri); } - } else if (isFromRemote && isToRemote) { + } else if (isFromRemote && isToRemote) { //NOSONAR throw new BuildException( "Copying from a remote server to a remote server is not supported."); } else {
