[
https://issues.apache.org/jira/browse/IVY-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028321#comment-16028321
]
ASF GitHub Bot commented on IVY-1528:
-------------------------------------
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
- we dont use @author
- TestXmlHelper
-- if xPathExpression would be a String and the method compiles that for
itself,
reuse would be easier
-- XmlHelper would be a better name, because does not work only on tests.
-- result could be inlined
- IvyMakePomTest#testClassifier()
-- you dont use expectedPomArtifactIds for assertions. Do you want to
check
emptyness after the loop?
> Makepom ignores dependency classifiers
> --------------------------------------
>
> Key: IVY-1528
> URL: https://issues.apache.org/jira/browse/IVY-1528
> Project: Ivy
> Issue Type: Bug
> Components: Maven Compatibility
> Affects Versions: 2.4.0
> Reporter: Matthias Hannen
> Priority: Critical
>
> The classifier of a dependency like
> {code:xml}
> <dependency org="foo" name="bar" rev="1.0.0" conf="optional->default"
> m:classifier="wsdl" />
> {code}
> is ignored by the makepom task. I also checked the code of IvyMakePom.java.
> The method to set the classifier of a dependency is never called anywhere.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
