https://bz.apache.org/bugzilla/show_bug.cgi?id=61305
Stefan Bodewig <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- OS| |All --- Comment #1 from Stefan Bodewig <[email protected]> --- I'm sure your changes would improve the quality of the Project class but at the same time it scares me. Project is a central class and we know there exist subclasses that are out of our control. AFAIK the components that integrate Ant into IDEs use subclasses of Project. We don't really know what those subclasses do. As long as they only override some methods your refactoring wouldn't break them, but they may rely upon a certain method calling another method, for example. Sometime last year I made an attribute final and promptly broke Eclipse's Ant integration - see bug 60582 I guess what I'm trying to say is be extra careful with this class and ensure the refactoring doesn't break any assumption anybody who knows the current code may have about the inner workings of the class. In the end this may mean you can't make all the changes that would improve the code. -- You are receiving this mail because: You are the assignee for the bug.
