Repository: ant-ivyde Updated Branches: refs/heads/master eec4eac35 -> 37347e53a
Checkstyle: make fields final Project: http://git-wip-us.apache.org/repos/asf/ant-ivyde/repo Commit: http://git-wip-us.apache.org/repos/asf/ant-ivyde/commit/37347e53 Tree: http://git-wip-us.apache.org/repos/asf/ant-ivyde/tree/37347e53 Diff: http://git-wip-us.apache.org/repos/asf/ant-ivyde/diff/37347e53 Branch: refs/heads/master Commit: 37347e53ae6cce42061482d14e5bee9b5adc6f79 Parents: eec4eac Author: Gintas Grigelionis <[email protected]> Authored: Sun Nov 5 12:59:06 2017 +0100 Committer: Gintas Grigelionis <[email protected]> Committed: Sun Nov 5 12:59:06 2017 +0100 ---------------------------------------------------------------------- .../resolvevisualizer/IvyNodeLabelProvider.java | 14 ++++++------- .../ResolveVisualizerForm.java | 12 +++++------ .../ResolveVisualizerView.java | 6 +++--- .../completion/CodeCompletionProposal.java | 12 +++++------ .../common/ivysettings/IvySettingsFile.java | 2 +- .../common/ivysettings/IvySettingsModel.java | 2 +- .../org/apache/ivyde/common/model/IvyFile.java | 10 ++++----- .../org/apache/ivyde/common/model/IvyModel.java | 2 +- .../org/apache/ivyde/common/model/Proposal.java | 6 +++--- .../apache/ivyde/eclipse/cp/ResolvedPath.java | 2 +- .../controller/SecuritySetupController.java | 6 +++--- .../cpcontainer/IvyClasspathContainerImpl.java | 2 +- .../IvyClasspathContainerMapper.java | 10 ++++----- .../IvyClasspathContainerSerializer.java | 5 ++--- .../eclipse/resolve/IvyResolveJobListener.java | 2 +- .../retrieve/StandaloneRetrieveSetup.java | 2 +- .../eclipse/revdepexplorer/SyncIvyFilesJob.java | 4 ++-- .../internal/eclipse/ui/AbstractSetupTab.java | 6 +++--- .../eclipse/ui/AdvancedSetupEditor.java | 4 ++-- .../eclipse/ui/ClasspathSetupEditor.java | 22 ++++++++++---------- .../eclipse/ui/ClasspathTypeComposite.java | 6 +++--- .../internal/eclipse/ui/ConfTableViewer.java | 10 ++++----- .../eclipse/ui/DecorationOverlayIcon.java | 4 ++-- .../internal/eclipse/ui/FileListEditor.java | 8 +++---- .../internal/eclipse/ui/MappingSetupEditor.java | 20 +++++++++--------- .../eclipse/ui/NewIvyDEContainerWizard.java | 2 +- .../ivyde/internal/eclipse/ui/PathEditor.java | 8 +++---- .../internal/eclipse/ui/PathEditorDialog.java | 6 +++--- .../internal/eclipse/ui/RetrieveComposite.java | 6 +++--- .../eclipse/ui/SecuritySetupEditor.java | 13 ++++++------ .../eclipse/ui/SettingsSetupEditor.java | 8 +++---- .../eclipse/ui/console/ConsoleDocument.java | 4 ++-- .../internal/eclipse/ui/console/IvyConsole.java | 8 +++---- .../ui/console/IvyConsoleFilterAction.java | 2 +- .../eclipse/ui/console/IvyDEMessageLogger.java | 2 +- .../eclipse/ui/core/IvyFileEditorInput.java | 2 +- .../ui/editors/IvyEditorPageDescriptor.java | 2 +- .../ModuleDescriptorExtensionDescriptor.java | 2 +- .../ui/editors/pages/IvyConfSection.java | 3 ++- .../ui/editors/pages/IvyInfoSection.java | 3 ++- .../editors/xml/IvyContentAssistProcessor.java | 2 +- .../xml/NonRuleBasedDamagerRepairer.java | 2 +- .../ui/editors/xml/XMLConfiguration.java | 4 ++-- .../eclipse/ui/editors/xml/XMLEditor.java | 4 ++-- .../eclipse/ui/menu/RetrieveAction.java | 2 +- .../EditStandaloneRetrieveDialog.java | 2 +- .../ui/preferences/IvyDEProjectPreferences.java | 2 +- .../eclipse/ui/wizards/IvyNewWizardPage.java | 2 +- .../eclipse/validator/BaseValidator.java | 2 +- .../eclipse/validator/impl/IdValidator.java | 6 +++--- .../reaction/GeneralValidationReaction.java | 7 ++++--- .../workspaceresolver/WorkspaceResolver.java | 8 +++---- 52 files changed, 147 insertions(+), 146 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java index 7b4164a..6417df9 100644 --- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java +++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/IvyNodeLabelProvider.java @@ -45,11 +45,11 @@ import org.eclipse.zest.core.widgets.ZestStyles; * Alters the color of the labels and connections based on the selected analysis algorithm. */ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStyleProvider, IEntityStyleProvider { - public Color GRAY = new Color(Display.getDefault(), 128, 128, 128); - public Color LIGHT_GRAY = new Color(Display.getDefault(), 220, 220, 220); - public Color BLACK = new Color(Display.getDefault(), 0, 0, 0); - public Color RED = new Color(Display.getDefault(), 255, 0, 0); - public Color LIGHT_GREEN = new Color(Display.getDefault(), 96, 255, 96); + public final Color GRAY = new Color(Display.getDefault(), 128, 128, 128); + public final Color LIGHT_GRAY = new Color(Display.getDefault(), 220, 220, 220); + public final Color BLACK = new Color(Display.getDefault(), 0, 0, 0); + public final Color RED = new Color(Display.getDefault(), 255, 0, 0); + public final Color LIGHT_GREEN = new Color(Display.getDefault(), 96, 255, 96); private IvyNodeElement selected = null; private IvyNodeElement rootNode = null; @@ -60,8 +60,8 @@ public class IvyNodeLabelProvider implements ILabelProvider, IConnectionStylePro private GraphViewer viewer; private ILabelDecoratorAlgorithm autoSelectDecorator = new ShortestRootPathAlgorithm(); - private DirectDependenciesAlgorithm rootDirectDependenciesDecorator = new DirectDependenciesAlgorithm(); - private ConfigurationConflictAlgorithm conflictDecorator = new ConfigurationConflictAlgorithm(); + private final DirectDependenciesAlgorithm rootDirectDependenciesDecorator = new DirectDependenciesAlgorithm(); + private final ConfigurationConflictAlgorithm conflictDecorator = new ConfigurationConflictAlgorithm(); private Color rootColor; private Color rootSelectedColor; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java index 8d5db19..3893c82 100644 --- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java +++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerForm.java @@ -79,11 +79,11 @@ import org.eclipse.zest.core.widgets.Graph; public class ResolveVisualizerForm { public static final String HEADER_TEXT = "Ivy Resolve Visualization"; - private FormToolkit toolkit; + private final FormToolkit toolkit; private GraphViewer viewer; - private ScrolledForm form; - private ManagedForm managedForm; - private ResolveVisualizerView view; + private final ScrolledForm form; + private final ManagedForm managedForm; + private final ResolveVisualizerView view; private Label searchLabel; private Text searchBox; @@ -103,8 +103,8 @@ public class ResolveVisualizerForm { private ThumbnailNavigator thumbnailNavigator; - private DepthFilter depthFilter = new DepthFilter(); - private EvictionFilter evictionFilter = new EvictionFilter(); + private final DepthFilter depthFilter = new DepthFilter(); + private final EvictionFilter evictionFilter = new EvictionFilter(); public ResolveVisualizerForm(Composite parent, FormToolkit toolkit, ResolveVisualizerView view) { this.toolkit = toolkit; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java index 43c4423..6e4fbac 100644 --- a/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java +++ b/org.apache.ivyde.eclipse.resolvevisualizer/src/org/apache/ivyde/eclipse/resolvevisualizer/ResolveVisualizerView.java @@ -94,12 +94,12 @@ public class ResolveVisualizerView extends ViewPart implements IZoomableWorkbenc private IvyNodeElement currentSelection; private IvyClasspathContainer currentContainer; - private ResolveVisualizerContentProvider contentProvider = new ResolveVisualizerContentProvider(); - private MessageContentProvider messageContentProvider = new MessageContentProvider(); + private final ResolveVisualizerContentProvider contentProvider = new ResolveVisualizerContentProvider(); + private final MessageContentProvider messageContentProvider = new MessageContentProvider(); private IvyNodeLabelProvider labelProvider; private ResolveVisualizerForm visualizationForm; - private ForceHiddenFilter forceHiddenFilter; + private final ForceHiddenFilter forceHiddenFilter; public ResolveVisualizerView() { historyStack = new Stack/* <IvyNodeElement> */(); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/CodeCompletionProposal.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/CodeCompletionProposal.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/CodeCompletionProposal.java index 955252d..408256f 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/CodeCompletionProposal.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/completion/CodeCompletionProposal.java @@ -20,22 +20,22 @@ package org.apache.ivyde.common.completion; public class CodeCompletionProposal { /** The string to be displayed in the completion proposal popup. */ - private String displayString; + private final String displayString; /** The replacement string. */ - private String replacementString; + private final String replacementString; /** The replacement offset. */ - private int replacementOffset; + private final int replacementOffset; /** The replacement length. */ - private int replacementLength; + private final int replacementLength; /** The cursor position after this proposal has been applied. */ - private int cursorPosition; + private final int cursorPosition; /** The documentation of this proposal. */ - private String doc; + private final String doc; public CodeCompletionProposal(String replacementString, int replacementOffset, int replacementLength, int cursorPosition) { http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsFile.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsFile.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsFile.java index 5d41a67..c3e3711 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsFile.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsFile.java @@ -45,7 +45,7 @@ public class IvySettingsFile extends IvyFile { private static final Pattern TYPEDEF_PATTERN = Pattern .compile("<[\\s]*typedef[^>]+name=\"([^\"]+)\"[^>]+classname=\"([^\"]+)"); - private File file; + private final File file; public IvySettingsFile(IvyModelSettings settings, File file, String projectName, String doc, int currentOffset) { http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java index 6ef6a57..ebe8155 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/ivysettings/IvySettingsModel.java @@ -48,7 +48,7 @@ import org.apache.ivyde.common.model.IvyTagAttribute; public class IvySettingsModel extends IvyModel { private String loaded = null; - private File file; + private final File file; private ClassLoader cl; private Map typedefClasses; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java index 4e0044b..9a73c68 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyFile.java @@ -32,15 +32,15 @@ public abstract class IvyFile { private static final Pattern ATTRIBUTE_VALUE_PATTERN = Pattern .compile("([a-zA-Z0-9]+)[ ]*=[ ]*\"([^\"]*)\""); - private String doc; + private final String doc; - private int currentOffset; + private final int currentOffset; - private String reversed; + private final String reversed; - private String projectName; + private final String projectName; - private IvyModelSettings settings; + private final IvyModelSettings settings; public IvyFile(IvyModelSettings settings, String projectName, String doc) { this(settings, projectName, doc, 0); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyModel.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyModel.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyModel.java index 2f46162..0b1d8a8 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyModel.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/IvyModel.java @@ -31,7 +31,7 @@ public abstract class IvyModel { private Properties defaults; - private IvyModelSettings settings; + private final IvyModelSettings settings; public IvyModel(IvyModelSettings settings) { loadDefaults(); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/Proposal.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/Proposal.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/Proposal.java index c46b8cd..3bdf6a2 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/Proposal.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/common/model/Proposal.java @@ -18,11 +18,11 @@ package org.apache.ivyde.common.model; public class Proposal { - private int cursor; + private final int cursor; - private String proposal; + private final String proposal; - private String doc; + private final String doc; public Proposal(String proposal, int cursor, String doc) { this.cursor = cursor; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/ResolvedPath.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/ResolvedPath.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/ResolvedPath.java index 2469d4f..93b12cc 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/ResolvedPath.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/eclipse/cp/ResolvedPath.java @@ -33,7 +33,7 @@ import org.eclipse.core.variables.VariablesPlugin; public class ResolvedPath { - private String inputPath; + private final String inputPath; private String resolvedPath; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java index 53516c6..2a6f492 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/controller/SecuritySetupController.java @@ -55,9 +55,9 @@ import org.eclipse.swt.widgets.Widget; public class SecuritySetupController { - private SecuritySetupEditor setupEditorGUI; + private final SecuritySetupEditor setupEditorGUI; - private SecuritySetupDialog addDialog; + private final SecuritySetupDialog addDialog; private MessageDialog confirmationDialog; @@ -73,7 +73,7 @@ public class SecuritySetupController { private boolean addOperation = true; - private DataBindingContext ctx = new DataBindingContext(); + private final DataBindingContext ctx = new DataBindingContext(); /** * @param setupEditorGUI SecuritySetupEditor http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerImpl.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerImpl.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerImpl.java index e43ee12..68f0a16 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerImpl.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerImpl.java @@ -50,7 +50,7 @@ public class IvyClasspathContainerImpl implements IClasspathContainer, IvyClassp private IClasspathEntry[] classpathEntries; - private IPath path; + private final IPath path; private IvyClasspathContainerConfiguration conf; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerMapper.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerMapper.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerMapper.java index 4c1b6c7..08b3da8 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerMapper.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerMapper.java @@ -77,15 +77,15 @@ public class IvyClasspathContainerMapper { private final Map<ArtifactDownloadReport, Set<String>> retrievedArtifacts; - private ClasspathSetup classpathSetup; + private final ClasspathSetup classpathSetup; - private MappingSetup mapping; + private final MappingSetup mapping; - private boolean osgiAvailable; + private final boolean osgiAvailable; - private boolean osgiClasspathAvailable; + private final boolean osgiClasspathAvailable; - private IvyAttachmentManager attachmentManager = IvyPlugin.getDefault() + private final IvyAttachmentManager attachmentManager = IvyPlugin.getDefault() .getIvyAttachmentManager(); public IvyClasspathContainerMapper(IProgressMonitor monitor, Ivy ivy, http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerSerializer.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerSerializer.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerSerializer.java index c9fb8de..c504d9d 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerSerializer.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/cpcontainer/IvyClasspathContainerSerializer.java @@ -28,7 +28,6 @@ import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; - import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; @@ -91,9 +90,9 @@ public class IvyClasspathContainerSerializer { private static final String PATTERN = "pattern"; - private File containersStateDir; + private final File containersStateDir; - private IvyAttachmentManager ivyAttachmentManager; + private final IvyAttachmentManager ivyAttachmentManager; public IvyClasspathContainerSerializer(File containersStateDir, IvyAttachmentManager ivyAttachmentManager) { http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/resolve/IvyResolveJobListener.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/resolve/IvyResolveJobListener.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/resolve/IvyResolveJobListener.java index 1bc9327..1c9b75f 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/resolve/IvyResolveJobListener.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/resolve/IvyResolveJobListener.java @@ -49,7 +49,7 @@ public class IvyResolveJobListener implements TransferListener, IvyListener { private final int downloadStep; - private int resolveStep; + private final int resolveStep; public IvyResolveJobListener(final IProgressMonitor monitor, int step) { this.monitor = monitor; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/retrieve/StandaloneRetrieveSetup.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/retrieve/StandaloneRetrieveSetup.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/retrieve/StandaloneRetrieveSetup.java index 878372c..1c83d29 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/retrieve/StandaloneRetrieveSetup.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/retrieve/StandaloneRetrieveSetup.java @@ -38,7 +38,7 @@ public class StandaloneRetrieveSetup { private IProject project; - private StandaloneRetrieveSetupState state = new StandaloneRetrieveSetupState(this); + private final StandaloneRetrieveSetupState state = new StandaloneRetrieveSetupState(this); public StandaloneRetrieveSetupState getState() { return state; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/revdepexplorer/SyncIvyFilesJob.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/revdepexplorer/SyncIvyFilesJob.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/revdepexplorer/SyncIvyFilesJob.java index 71d2960..2191b81 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/revdepexplorer/SyncIvyFilesJob.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/revdepexplorer/SyncIvyFilesJob.java @@ -58,7 +58,7 @@ import org.xml.sax.SAXException; */ public class SyncIvyFilesJob extends WorkspaceJob { - private MultiRevDependencyDescriptor[] multiRevisionDependencies; + private final MultiRevDependencyDescriptor[] multiRevisionDependencies; /** * FIXME Here we seriously abuse the Ivy core API to allow us to preserve an info element @@ -67,7 +67,7 @@ public class SyncIvyFilesJob extends WorkspaceJob { */ private class RevisionPreservingNamespace extends Namespace { private class NullableRevisionModuleRevisionId extends ModuleRevisionId { - private String revision; + private final String revision; public NullableRevisionModuleRevisionId(ModuleId moduleId, String revision) { super(moduleId, revision); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AbstractSetupTab.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AbstractSetupTab.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AbstractSetupTab.java index b979233..78cd8e0 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AbstractSetupTab.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AbstractSetupTab.java @@ -34,11 +34,11 @@ import org.eclipse.ui.dialogs.PreferencesUtil; public abstract class AbstractSetupTab { - private Button projectSpecificButton; + private final Button projectSpecificButton; - private Link mainGeneralSettingsLink; + private final Link mainGeneralSettingsLink; - private Composite setupEditor; + private final Composite setupEditor; public AbstractSetupTab(final TabFolder tabs, String title, final String preferencePageId, IProject project) { TabItem tab = new TabItem(tabs, SWT.NONE); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AdvancedSetupEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AdvancedSetupEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AdvancedSetupEditor.java index 4115293..4beecf7 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AdvancedSetupEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/AdvancedSetupEditor.java @@ -26,9 +26,9 @@ import org.eclipse.swt.widgets.Composite; public class AdvancedSetupEditor extends Composite { - private Button resolveBeforeLaunchCheck; + private final Button resolveBeforeLaunchCheck; - private Button useExtendedResolveIdCheck; + private final Button useExtendedResolveIdCheck; public AdvancedSetupEditor(Composite parent, int style) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathSetupEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathSetupEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathSetupEditor.java index ee8369d..d372b72 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathSetupEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathSetupEditor.java @@ -41,27 +41,27 @@ public class ClasspathSetupEditor extends Composite { public static final String TOOLTIP_ACCEPTED_TYPES = "Comma separated list of artifact types to add to the classpath.\n" + "Example: jar, zip"; - private Button resolveInWorkspaceCheck; + private final Button resolveInWorkspaceCheck; - private Button transitiveResolveCheck; + private final Button transitiveResolveCheck; - private Label alphaOrderLabel; + private final Label alphaOrderLabel; - private Combo alphaOrderCheck; + private final Combo alphaOrderCheck; - private Button selectCache; + private final Button selectCache; - private Button selectRetrieve; + private final Button selectRetrieve; - private RetrieveComposite retrieveComposite; + private final RetrieveComposite retrieveComposite; - private Label acceptedTypesLabel; + private final Label acceptedTypesLabel; - private Text acceptedTypesText; + private final Text acceptedTypesText; - private Button readOSGiMetadataCheck; + private final Button readOSGiMetadataCheck; - private boolean osgiAvailable; + private final boolean osgiAvailable; public ClasspathSetupEditor(Composite parent, int style, IProject project) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathTypeComposite.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathTypeComposite.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathTypeComposite.java index d5c4c92..b344918 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathTypeComposite.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ClasspathTypeComposite.java @@ -34,11 +34,11 @@ public class ClasspathTypeComposite extends Composite { private static final int INDENT_RETRIEVE = 60; - private Button selectRetrieve; + private final Button selectRetrieve; - private RetrieveComposite retrieveComposite; + private final RetrieveComposite retrieveComposite; - private Button selectCache; + private final Button selectCache; public ClasspathTypeComposite(Composite parent, int style, IProject project) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ConfTableViewer.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ConfTableViewer.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ConfTableViewer.java index 4b73cab..d9e9092 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ConfTableViewer.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/ConfTableViewer.java @@ -47,17 +47,17 @@ public class ConfTableViewer extends Composite { private final List listeners = new ArrayList(); - private Button selectAll; + private final Button selectAll; - private Button up; + private final Button up; - private Button down; + private final Button down; private Configuration[] orderedConfigurations = new Configuration[0]; - private Button all; + private final Button all; - private Button none; + private final Button none; public ConfTableViewer(Composite parent, int style) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/DecorationOverlayIcon.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/DecorationOverlayIcon.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/DecorationOverlayIcon.java index 371489a..45e1b62 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/DecorationOverlayIcon.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/DecorationOverlayIcon.java @@ -28,9 +28,9 @@ import org.eclipse.swt.graphics.Point; */ public class DecorationOverlayIcon extends CompositeImageDescriptor { - private Image baseImage; + private final Image baseImage; - private Point size; + private final Point size; private final ImageDescriptor overlayImage; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/FileListEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/FileListEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/FileListEditor.java index fff8cff..e91c6f7 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/FileListEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/FileListEditor.java @@ -39,19 +39,19 @@ import org.eclipse.swt.widgets.Label; public class FileListEditor extends Composite { - private ListViewer filelist; + private final ListViewer filelist; private List/* <String> */files = new ArrayList(); private Button edit; - private Button add; + private final Button add; private Button remove; - private Button up; + private final Button up; - private Button down; + private final Button down; public FileListEditor(Composite parent, int style, String label, final String labelPopup, final IProject project, final String defaultExtension) { http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/MappingSetupEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/MappingSetupEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/MappingSetupEditor.java index 826c038..c8d9c02 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/MappingSetupEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/MappingSetupEditor.java @@ -49,25 +49,25 @@ public class MappingSetupEditor extends Composite { + " to all jar artifact in modules with multiple jar artifacts and only one" + " javadoc artifact"; - private Text sourceTypesText; + private final Text sourceTypesText; - private Text sourceSuffixesText; + private final Text sourceSuffixesText; - private Text javadocTypesText; + private final Text javadocTypesText; - private Text javadocSuffixesText; + private final Text javadocSuffixesText; - private Button mapIfOnlyOneSourceCheck; + private final Button mapIfOnlyOneSourceCheck; - private Button mapIfOnlyOneJavadocCheck; + private final Button mapIfOnlyOneJavadocCheck; - private Label sourceTypesLabel; + private final Label sourceTypesLabel; - private Label sourceSuffixesLabel; + private final Label sourceSuffixesLabel; - private Label javadocTypesLabel; + private final Label javadocTypesLabel; - private Label javadocSuffixesLabel; + private final Label javadocSuffixesLabel; public MappingSetupEditor(Composite parent, int style) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/NewIvyDEContainerWizard.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/NewIvyDEContainerWizard.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/NewIvyDEContainerWizard.java index 15a8750..70fcbc5 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/NewIvyDEContainerWizard.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/NewIvyDEContainerWizard.java @@ -36,7 +36,7 @@ import org.eclipse.jface.wizard.Wizard; public class NewIvyDEContainerWizard extends Wizard { - private IvydeContainerPage containerPage; + private final IvydeContainerPage containerPage; public NewIvyDEContainerWizard(IJavaProject project, IFile ivyfile) { containerPage = new IvydeContainerPage(); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditor.java index c4844bc..8f6c0ab 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditor.java @@ -44,13 +44,13 @@ import org.eclipse.ui.model.WorkbenchLabelProvider; public class PathEditor extends Composite { - private Text text; + private final Text text; - private Button variableButton; + private final Button variableButton; - private Button browseFileSystem; + private final Button browseFileSystem; - private Button browseWorkspace; + private final Button browseWorkspace; private final IProject project; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditorDialog.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditorDialog.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditorDialog.java index fd0ece7..ef5b4d4 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditorDialog.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/PathEditorDialog.java @@ -27,11 +27,11 @@ import org.eclipse.swt.widgets.Shell; public class PathEditorDialog extends Dialog { - private String label; + private final String label; - private IProject project; + private final IProject project; - private String defaultExtension; + private final String defaultExtension; private PathEditor editor; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/RetrieveComposite.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/RetrieveComposite.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/RetrieveComposite.java index ca01a87..d4f910b 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/RetrieveComposite.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/RetrieveComposite.java @@ -43,13 +43,13 @@ public class RetrieveComposite extends Composite { private static final String DEFAULT_PATTERN = "/[type]s/[artifact]-[revision](-[classifier]).[ext]"; - private PathEditor retrievePatternText; + private final PathEditor retrievePatternText; - private Button retrieveSyncButton; + private final Button retrieveSyncButton; private Text confsText; - private Text typesText; + private final Text typesText; public RetrieveComposite(Composite parent, int style, boolean withConf, IProject project) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SecuritySetupEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SecuritySetupEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SecuritySetupEditor.java index e16cfe0..d4547b2 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SecuritySetupEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SecuritySetupEditor.java @@ -33,13 +33,12 @@ import org.eclipse.swt.widgets.Table; public class SecuritySetupEditor extends Composite { - private TableViewer tableViewer; - private Group credentialsGroup; - private Button addBtn; - private Button editBtn; - private Button deleteBtn; - private Table table; - + private final TableViewer tableViewer; + private final Group credentialsGroup; + private final Button addBtn; + private final Button editBtn; + private final Button deleteBtn; + private final Table table; public SecuritySetupEditor(Composite parent, int style) { super(parent, style); setLayout(new GridLayout()); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SettingsSetupEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SettingsSetupEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SettingsSetupEditor.java index fe28fd0..eaf1284 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SettingsSetupEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/SettingsSetupEditor.java @@ -57,17 +57,17 @@ public class SettingsSetupEditor extends Composite { private FieldDecoration errorDecoration; - private FileListEditor propFilesEditor; + private final FileListEditor propFilesEditor; private DecoratedField settingsTextDeco; - private Button loadOnDemandButton; + private final Button loadOnDemandButton; - private PathEditor settingsEditor; + private final PathEditor settingsEditor; private Button defaultButton; - private PathEditor ivyUserDirEditor; + private final PathEditor ivyUserDirEditor; public SettingsSetupEditor(Composite parent, int style, IProject project) { super(parent, style); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/ConsoleDocument.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/ConsoleDocument.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/ConsoleDocument.java index 911336f..451ed6a 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/ConsoleDocument.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/ConsoleDocument.java @@ -30,9 +30,9 @@ public class ConsoleDocument { private static final int BUFFER_SIZE = 200; protected static class ConsoleLine { - private String line; + private final String line; - private int type; + private final int type; ConsoleLine(String line, int type) { this.line = line; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsole.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsole.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsole.java index c56466e..6c32111 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsole.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsole.java @@ -52,11 +52,11 @@ public class IvyConsole extends MessageConsole implements MessageLogger { public static final String PREF_CONSOLE_ERROR_COLOR = IvyPlugin.ID + ".console.color.error"; // CheckStyle:MagicNumber| OFF - private MessageConsoleStream[] streams = new MessageConsoleStream[5]; + private final MessageConsoleStream[] streams = new MessageConsoleStream[5]; // CheckStyle:MagicNumber| ON - private ConsoleDocument document; + private final ConsoleDocument document; private boolean initialized = false; @@ -64,11 +64,11 @@ public class IvyConsole extends MessageConsole implements MessageLogger { private boolean showOnMessage; - private IConsoleManager consoleManager; + private final IConsoleManager consoleManager; private int logLevel; - private IvyDEMessageLogger ivyDEMessageLogger; + private final IvyDEMessageLogger ivyDEMessageLogger; public IvyConsole() { this("Ivy", IvyPlugin.getImageDescriptor("icons/logo16x16.gif")); //$NON-NLS-1$ http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsoleFilterAction.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsoleFilterAction.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsoleFilterAction.java index d3f10f2..490b568 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsoleFilterAction.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyConsoleFilterAction.java @@ -32,7 +32,7 @@ public class IvyConsoleFilterAction extends Action implements IMenuCreator { private Menu fMenu; - private IvyConsole console; + private final IvyConsole console; public IvyConsoleFilterAction(IvyConsole console) { this.console = console; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyDEMessageLogger.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyDEMessageLogger.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyDEMessageLogger.java index ea51c49..0d9258e 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyDEMessageLogger.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/console/IvyDEMessageLogger.java @@ -26,7 +26,7 @@ import org.apache.ivyde.internal.eclipse.IvyPlugin; public class IvyDEMessageLogger implements MessageLogger { - private IvyConsole console; + private final IvyConsole console; private int logLevel; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/core/IvyFileEditorInput.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/core/IvyFileEditorInput.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/core/IvyFileEditorInput.java index 947b29f..d08aa3b 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/core/IvyFileEditorInput.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/core/IvyFileEditorInput.java @@ -28,7 +28,7 @@ import org.eclipse.ui.IPersistableElement; import org.eclipse.ui.IStorageEditorInput; public class IvyFileEditorInput implements IPathEditorInput, IStorageEditorInput, IFileEditorInput { - private IFile ivyFile; + private final IFile ivyFile; public IvyFileEditorInput(IFile input) { super(); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/IvyEditorPageDescriptor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/IvyEditorPageDescriptor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/IvyEditorPageDescriptor.java index 528f629..a6da920 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/IvyEditorPageDescriptor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/IvyEditorPageDescriptor.java @@ -32,7 +32,7 @@ public class IvyEditorPageDescriptor { private static final String CLASS_ATTRIBUTE = "pageClass"; - private IConfigurationElement element; + private final IConfigurationElement element; public IvyEditorPageDescriptor(final IConfigurationElement element) { this.element = element; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/ModuleDescriptorExtensionDescriptor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/ModuleDescriptorExtensionDescriptor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/ModuleDescriptorExtensionDescriptor.java index d393f2e..b5dab4d 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/ModuleDescriptorExtensionDescriptor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/ModuleDescriptorExtensionDescriptor.java @@ -31,7 +31,7 @@ public class ModuleDescriptorExtensionDescriptor { public static final String MODEL_CONTRIBUTOR_CLASS_ATTRIBUTE = "modelContributorClass"; - private IConfigurationElement element; + private final IConfigurationElement element; public ModuleDescriptorExtensionDescriptor(final IConfigurationElement element) { this.element = element; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyConfSection.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyConfSection.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyConfSection.java index 0f28519..aed687d 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyConfSection.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyConfSection.java @@ -28,7 +28,8 @@ import org.eclipse.ui.forms.widgets.TableWrapData; import org.eclipse.ui.forms.widgets.TableWrapLayout; public class IvyConfSection extends SectionPart { - private IFormPage page; + @SuppressWarnings("unused") + private final IFormPage page; private static final int NUM_COLUMNS = 2; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyInfoSection.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyInfoSection.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyInfoSection.java index 70a1599..7d8b354 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyInfoSection.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/pages/IvyInfoSection.java @@ -32,7 +32,8 @@ import org.eclipse.ui.forms.widgets.TableWrapData; import org.eclipse.ui.forms.widgets.TableWrapLayout; public class IvyInfoSection extends SectionPart implements PropertyChangeListener { - private IFormPage page; + @SuppressWarnings("unused") + private final IFormPage page; private static final int NUM_COLUMNS = 2; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/IvyContentAssistProcessor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/IvyContentAssistProcessor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/IvyContentAssistProcessor.java index 16cf099..6f8d79b 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/IvyContentAssistProcessor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/IvyContentAssistProcessor.java @@ -38,7 +38,7 @@ import org.eclipse.jface.text.contentassist.IContextInformationValidator; import org.eclipse.swt.graphics.Point; public abstract class IvyContentAssistProcessor implements IContentAssistProcessor { - private IContextInformationValidator fValidator = new ContextInformationValidator(this); + private final IContextInformationValidator fValidator = new ContextInformationValidator(this); private String errorMessage = null; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/NonRuleBasedDamagerRepairer.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/NonRuleBasedDamagerRepairer.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/NonRuleBasedDamagerRepairer.java index 94b20f7..fd78b2d 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/NonRuleBasedDamagerRepairer.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/NonRuleBasedDamagerRepairer.java @@ -37,7 +37,7 @@ public class NonRuleBasedDamagerRepairer implements IPresentationDamager, IPrese private IDocument fDocument; /** The default text attribute if non is returned as data by the current token */ - private TextAttribute fDefaultTextAttribute; + private final TextAttribute fDefaultTextAttribute; /** * Constructor for NonRuleBasedDamagerRepairer. http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLConfiguration.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLConfiguration.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLConfiguration.java index dad537a..88efcac 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLConfiguration.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLConfiguration.java @@ -42,9 +42,9 @@ public class XMLConfiguration extends SourceViewerConfiguration { private XMLScanner scanner; - private ColorManager colorManager; + private final ColorManager colorManager; - private IvyContentAssistProcessor processor; + private final IvyContentAssistProcessor processor; private IFile file; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLEditor.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLEditor.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLEditor.java index dbf4b1f..60cffef 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLEditor.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/editors/xml/XMLEditor.java @@ -27,7 +27,7 @@ import org.eclipse.ui.texteditor.TextOperationAction; public class XMLEditor extends TextEditor { - private ColorManager colorManager; + private final ColorManager colorManager; public XMLEditor(IvyContentAssistProcessor processor) { super(); @@ -40,7 +40,7 @@ public class XMLEditor extends TextEditor { private static final String CONTENTASSIST_PROPOSAL_ID = "org.apache.ivyde.ContentAssistProposal"; - private XMLConfiguration configuration; + private final XMLConfiguration configuration; protected void createActions() { super.createActions(); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/menu/RetrieveAction.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/menu/RetrieveAction.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/menu/RetrieveAction.java index b6fae5f..f1ff591 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/menu/RetrieveAction.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/menu/RetrieveAction.java @@ -32,7 +32,7 @@ public class RetrieveAction extends Action { private final StandaloneRetrieveSetup setup; - private IvyResolveJob ivyResolveJob; + private final IvyResolveJob ivyResolveJob; public RetrieveAction(StandaloneRetrieveSetup retrieveSetup) { this.setup = retrieveSetup; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/EditStandaloneRetrieveDialog.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/EditStandaloneRetrieveDialog.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/EditStandaloneRetrieveDialog.java index 9d2c255..fc44d0c 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/EditStandaloneRetrieveDialog.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/EditStandaloneRetrieveDialog.java @@ -41,7 +41,7 @@ public class EditStandaloneRetrieveDialog extends Dialog { private Text nameText; - private StandaloneRetrieveSetup retrieveSetup; + private final StandaloneRetrieveSetup retrieveSetup; private IvyFilePathText ivyFilePathText; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/IvyDEProjectPreferences.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/IvyDEProjectPreferences.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/IvyDEProjectPreferences.java index e1d96e2..955bc7b 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/IvyDEProjectPreferences.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/preferences/IvyDEProjectPreferences.java @@ -54,7 +54,7 @@ public class IvyDEProjectPreferences extends PropertyPage implements IWorkbenchP private TableViewer table; - private RetrieveSetupManager retrieveSetupManager; + private final RetrieveSetupManager retrieveSetupManager; public IvyDEProjectPreferences() { noDefaultAndApplyButton(); http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/wizards/IvyNewWizardPage.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/wizards/IvyNewWizardPage.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/wizards/IvyNewWizardPage.java index 13437d5..03801a2 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/wizards/IvyNewWizardPage.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/ui/wizards/IvyNewWizardPage.java @@ -57,7 +57,7 @@ public class IvyNewWizardPage extends WizardPage { private Combo statusText; - private ISelection selection; + private final ISelection selection; /** * Constructor for SampleNewWizardPage. http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/BaseValidator.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/BaseValidator.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/BaseValidator.java index 771d736..26dce1c 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/BaseValidator.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/BaseValidator.java @@ -22,7 +22,7 @@ import org.eclipse.core.runtime.IStatus; public abstract class BaseValidator implements IValidator { - private IValidationReaction reaction; + private final IValidationReaction reaction; private IStatus validationStatus; http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/impl/IdValidator.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/impl/IdValidator.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/impl/IdValidator.java index f3d3ac8..bd0f6f8 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/impl/IdValidator.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/impl/IdValidator.java @@ -25,11 +25,11 @@ import org.eclipse.core.runtime.IStatus; public class IdValidator extends BaseValidator { - private boolean isAddOperation; + private final boolean isAddOperation; - private String prevHostVal; + private final String prevHostVal; - private String prevRealmVal; + private final String prevRealmVal; /** * @param reaction IValidationReaction http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/reaction/GeneralValidationReaction.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/reaction/GeneralValidationReaction.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/reaction/GeneralValidationReaction.java index 30b7198..a6a1346 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/reaction/GeneralValidationReaction.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/validator/reaction/GeneralValidationReaction.java @@ -25,11 +25,12 @@ import org.eclipse.swt.widgets.Label; public class GeneralValidationReaction implements IValidationReaction { - private Button okButton; + private final Button okButton; - private Label errorLabel; + @SuppressWarnings("unused") + private final Label errorLabel; - private Label errorIcon; + private final Label errorIcon; @Override public void ok() { http://git-wip-us.apache.org/repos/asf/ant-ivyde/blob/37347e53/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/workspaceresolver/WorkspaceResolver.java ---------------------------------------------------------------------- diff --git a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/workspaceresolver/WorkspaceResolver.java b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/workspaceresolver/WorkspaceResolver.java index 49ae76a..6d7c553 100644 --- a/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/workspaceresolver/WorkspaceResolver.java +++ b/org.apache.ivyde.eclipse/src/java/org/apache/ivyde/internal/eclipse/workspaceresolver/WorkspaceResolver.java @@ -111,13 +111,13 @@ public class WorkspaceResolver extends AbstractResolver { public static final String IVYDE_WORKSPACE_ARTIFACT_REPORTS = "IvyDEWorkspaceArtifactReports"; - private IProject[] projects; + private final IProject[] projects; - private boolean ignoreBranchOnWorkspaceProjects; + private final boolean ignoreBranchOnWorkspaceProjects; - private boolean ignoreVersionOnWorkspaceProjects; + private final boolean ignoreVersionOnWorkspaceProjects; - private boolean osgiResolveInWorkspaceAvailable; + private final boolean osgiResolveInWorkspaceAvailable; public WorkspaceResolver(IProject project, IvySettings ivySettings) { String projectName = project == null ? "<null>" : project.getName();
