Repository: ant
Updated Branches:
  refs/heads/master 1fbf71253 -> 9873bf6c8


another evil PrintWriter introduced by Java8 refactoring


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/37210954
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/37210954
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/37210954

Branch: refs/heads/master
Commit: 37210954e57bfe2614137fc98de2f50e81a3bf34
Parents: 1fbf712
Author: Stefan Bodewig <bode...@apache.org>
Authored: Wed Feb 14 14:05:32 2018 +0100
Committer: Stefan Bodewig <bode...@apache.org>
Committed: Wed Feb 14 14:07:36 2018 +0100

----------------------------------------------------------------------
 .../taskdefs/optional/native2ascii/BuiltinNative2Ascii.java   | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/37210954/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java
----------------------------------------------------------------------
diff --git 
a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java
 
b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java
index 6cdf903..54ddc0a 100644
--- 
a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java
+++ 
b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java
@@ -25,7 +25,6 @@ import java.io.FileWriter;
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.io.OutputStreamWriter;
-import java.io.PrintWriter;
 import java.io.Writer;
 import java.nio.file.Files;
 import java.util.function.UnaryOperator;
@@ -33,6 +32,7 @@ import java.util.function.UnaryOperator;
 import org.apache.tools.ant.BuildException;
 import org.apache.tools.ant.taskdefs.optional.Native2Ascii;
 import org.apache.tools.ant.util.Native2AsciiUtils;
+import org.apache.tools.ant.util.StringUtils;
 
 /**
  * Encapsulates the built-in Native2Ascii implementation.
@@ -83,11 +83,10 @@ public class BuiltinNative2Ascii implements 
Native2AsciiAdapter {
 
     private void translate(BufferedReader input, Writer output,
         UnaryOperator<String> translation) throws IOException {
-        PrintWriter pw = new PrintWriter(output);
-
         for (String line : (Iterable<String>) () -> input.lines()
             .map(translation).iterator()) {
-            pw.println(line);
+            output.write(line);
+            output.write(StringUtils.LINE_SEP);
         }
     }
 }

Reply via email to