Checkstyle Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/a4099af8 Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/a4099af8 Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/a4099af8
Branch: refs/heads/master Commit: a4099af879d918764300af4c72a540382c7163a8 Parents: d3ea424 Author: Gintas Grigelionis <gin...@apache.org> Authored: Fri Apr 6 22:36:08 2018 +0200 Committer: Gintas Grigelionis <gin...@apache.org> Committed: Fri Apr 6 22:36:08 2018 +0200 ---------------------------------------------------------------------- src/main/org/apache/tools/ant/taskdefs/JDBCTask.java | 2 +- src/tests/antunit/core/uuencode/src/task/BaseTask.java | 2 +- .../junit/org/apache/tools/ant/taskdefs/ManifestTest.java | 8 ++++---- src/tests/junit/org/apache/tools/ant/taskdefs/TouchTest.java | 2 +- .../junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java | 4 ++-- src/tests/junit/org/apache/tools/ant/types/MapperTest.java | 2 +- .../org/apache/tools/ant/util/LazyFileOutputStreamTest.java | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/main/org/apache/tools/ant/taskdefs/JDBCTask.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/tools/ant/taskdefs/JDBCTask.java b/src/main/org/apache/tools/ant/taskdefs/JDBCTask.java index 6377d28..fdfdc39 100644 --- a/src/main/org/apache/tools/ant/taskdefs/JDBCTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/JDBCTask.java @@ -60,7 +60,7 @@ public class SQLExampleTask extends JDBCTask { Statement stmt=null; try { if (tableName == null) { - throw new BuildException("TableName must be specified",location); + throw new BuildException("TableName must be specified", location); } String sql = "SELECT * FROM "+tableName; stmt= conn.createStatement(); http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/tests/antunit/core/uuencode/src/task/BaseTask.java ---------------------------------------------------------------------- diff --git a/src/tests/antunit/core/uuencode/src/task/BaseTask.java b/src/tests/antunit/core/uuencode/src/task/BaseTask.java index 70eb7a3..cfb30b1 100644 --- a/src/tests/antunit/core/uuencode/src/task/BaseTask.java +++ b/src/tests/antunit/core/uuencode/src/task/BaseTask.java @@ -31,7 +31,7 @@ import java.io.OutputStream; * Base class for the uuencode/decode test tasks. */ abstract public class BaseTask extends Task { - private final static FileUtils FILE_UTILS = FileUtils.getFileUtils(); + private static final FileUtils FILE_UTILS = FileUtils.getFileUtils(); private File inFile; private File outFile; http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java ---------------------------------------------------------------------- diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java index 3dbcdf1..f8bd329 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestTest.java @@ -55,10 +55,10 @@ public class ManifestTest { private File outDir; public static final String LONG_LINE - = "AReallyLongLineToTestLineBreakingInManifests-ACapabilityWhich" + - "IsSureToLeadToHundredsOfQuestionsAboutWhyAntMungesManifests" + - "OfCourseTheAnswerIsThatIsWhatTheSpecRequiresAndIfAnythingHas" + - "AProblemWithThatItIsNotABugInAnt"; + = "AReallyLongLineToTestLineBreakingInManifests-ACapabilityWhich" + + "IsSureToLeadToHundredsOfQuestionsAboutWhyAntMungesManifests" + + "OfCourseTheAnswerIsThatIsWhatTheSpecRequiresAndIfAnythingHas" + + "AProblemWithThatItIsNotABugInAnt"; public static final String LONG_70_NAME = "ThisNameIsJustSeventyCharactersWhichIsAllowedAccordingToTheSpecsFiller"; http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/tests/junit/org/apache/tools/ant/taskdefs/TouchTest.java ---------------------------------------------------------------------- diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/TouchTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/TouchTest.java index 0f90146..80a0884 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/TouchTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/TouchTest.java @@ -193,7 +193,7 @@ public class TouchTest { * @param timestamp long * @param time long */ - public void assertTimesNearlyMatch(long timestamp,long time) { + public void assertTimesNearlyMatch(long timestamp, long time) { long granularity= FILE_UTILS.getFileTimestampGranularity(); assertTimesNearlyMatch(timestamp, time, granularity); } http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java ---------------------------------------------------------------------- diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java index fb3cde2..379f6be 100644 --- a/src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java +++ b/src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java @@ -332,7 +332,7 @@ public class XmlPropertyTest { * Retrieve a list of xml files in the specified folder * and below. */ - private static Enumeration<File> getFiles (final File startingDir) { + private static Enumeration<File> getFiles(final File startingDir) { Vector<File> result = new Vector<>(); getFiles(startingDir, result); return result.elements(); @@ -342,7 +342,7 @@ public class XmlPropertyTest { * Collect a list of xml files in the specified folder * and below. */ - private static void getFiles (final File startingDir, Vector<File> collect) { + private static void getFiles(final File startingDir, Vector<File> collect) { FileFilter filter = file -> { if (file.isDirectory()) { return true; http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/tests/junit/org/apache/tools/ant/types/MapperTest.java ---------------------------------------------------------------------- diff --git a/src/tests/junit/org/apache/tools/ant/types/MapperTest.java b/src/tests/junit/org/apache/tools/ant/types/MapperTest.java index 37433ea..3949a15 100644 --- a/src/tests/junit/org/apache/tools/ant/types/MapperTest.java +++ b/src/tests/junit/org/apache/tools/ant/types/MapperTest.java @@ -222,7 +222,7 @@ public class MapperTest { String[] targets = fileNameMapper.mapFileName("a"); assertNotNull("no filenames mapped", targets); assertEquals("wrong number of filenames mapped", 2, targets.length); - List list = Arrays.asList(targets); + List<String> list = Arrays.asList(targets); assertTrue("cannot find expected target \"def\"", list.contains("def")); assertTrue("cannot find expected target \"ghi\"", list.contains("ghi")); http://git-wip-us.apache.org/repos/asf/ant/blob/a4099af8/src/tests/junit/org/apache/tools/ant/util/LazyFileOutputStreamTest.java ---------------------------------------------------------------------- diff --git a/src/tests/junit/org/apache/tools/ant/util/LazyFileOutputStreamTest.java b/src/tests/junit/org/apache/tools/ant/util/LazyFileOutputStreamTest.java index 2a4cbf7..513472c 100644 --- a/src/tests/junit/org/apache/tools/ant/util/LazyFileOutputStreamTest.java +++ b/src/tests/junit/org/apache/tools/ant/util/LazyFileOutputStreamTest.java @@ -31,7 +31,7 @@ import static org.junit.Assert.assertTrue; */ public class LazyFileOutputStreamTest { private LazyFileOutputStream los; - private final static File f = new File("test.txt"); + private static final File f = new File("test.txt"); @Before public void setUp() {
