https://bz.apache.org/bugzilla/show_bug.cgi?id=64836

--- Comment #8 from Filipe Silva <filipe.si...@oracle.com> ---
Hi Jaikiran,

Finally I had some time to experiment your build.

I see you made the new summary pretty much like the old one from the junit task
with only a few differences in the fields displayed. It seems to be working
fine but I have a few remarks:

* The new summary is currently showing the fields "Tests run", "Failures",
"Skipped" and "Time elapsed". Can't you also include "Aborted"? I think you
should be able to extract it form the Junit 5 summary. E.g.:

    [junitlauncher] Tests run: 6, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0,007 sec

* Your "Time elapsed" information formatted with a dot (.) as decimal
separator. Can't you make it region based? In my region it should be formatted
with a comma (,).

* Indentation. I don't know if you can do something about this. Currently it is
printing this:

test:
    [mkdir] Created dir: /home/...
     [echo] Running my tests with jvm '/usr/lib/jvm/jdk-8/bin/java'
[junitlauncher] Tests run: 0, Failures: 0, Skipped: 0, Time elapsed: 0.05 sec
[junitlauncher] Running test.MyTest1
[junitlauncher] Tests run: 18, Failures: 0, Skipped: 0, Time elapsed: 132.978
sec
...

  While a similar run with the old junit task prints this:

test:
    [mkdir] Created dir: /home/...
     [echo] Running my tests jvm '/usr/lib/jvm/jdk-5/bin/java'
    [junit] Running test.MyTest1
    [junit] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
4,587 sec
...

  I don't know if this is because the word "junitlauncher" is too long for the
reserved space (it seems that prefixes are right aligned at column 11) or
something else. It just doesn't look that nice.

* I don't know if you see this too, but in my project there's always an empty
container being executed first. Using your build, this is the first
[junitlaucher] line:

[junitlauncher] Tests run: 0, Failures: 0, Skipped: 0, Time elapsed: 0.05 sec

  I know this is not exclusive to your build because previously I had the
following before running and showing the containers that actually have tests on
them:

[junitlauncher] 
[junitlauncher] Test run finished after 52 ms
[junitlauncher] [         1 containers found      ]
[junitlauncher] [         0 containers skipped    ]
[junitlauncher] [         1 containers started    ]
[junitlauncher] [         0 containers aborted    ]
[junitlauncher] [         1 containers successful ]
[junitlauncher] [         0 containers failed     ]
[junitlauncher] [         0 tests found           ]
[junitlauncher] [         0 tests skipped         ]
[junitlauncher] [         0 tests started         ]
[junitlauncher] [         0 tests aborted         ]
[junitlauncher] [         0 tests successful      ]
[junitlauncher] [         0 tests failed          ]

  Perhaps this is caused by the way I have my tests organized, but I haven't
figured out why, yet. I just know that there's no class name associated with
this container. 

  It would be nice if you could do something about this "empty" line too.


That's all from me at the moment.

Many thanks of your great work!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to