lyyoung commented on a change in pull request #794: Feature prometheus
URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341840808
 
 

 ##########
 File path: lua/apisix/plugins/prometheus/exporter.lua
 ##########
 @@ -44,26 +47,35 @@ function _M.init()
     -- per service
     metrics.status = prometheus:counter("http_status",
             "HTTP status codes per service in Apisix",
-            {"code", "service"})
+            {"code", "service", "node"})
+
+    metrics.latency = prometheus:histogram("http_latency",
+        "HTTP request latency per service in Apisix",
 
 Review comment:
   Okay. etcd_reachable/status/bandwidth also need to change Apisix to APISIX, 
as follows:
   "Config server etcd reachable from Apisix, 0 is unreachable" -> "Config 
server etcd reachable from APISIX, 0 is unreachable"
   "HTTP status codes per service in Apisix" -> "HTTP status codes per service 
in APISIX"
   "Total bandwidth in bytes consumed per service in Apisix" -> "Total 
bandwidth in bytes consumed per service in APISIX"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to