membphis commented on a change in pull request #822: change: don't strip square 
brackets from the IPv6
URL: https://github.com/apache/incubator-apisix/pull/822#discussion_r344445200
 
 

 ##########
 File path: rockspec/apisix-master-0.rockspec
 ##########
 @@ -48,6 +48,7 @@ dependencies = {
     "lua-tinyyaml = 0.1",
     "iresty-nginx-lua-prometheus = 0.20190917",
     "jsonschema = 0.4",
+    "lua-resty-ipmatcher = 0.3",
 
 Review comment:
   We can remove this line, and update `lua-resty-radixtree` to `1.6-1`:
   
   ```diff
   --- a/rockspec/apisix-master-0.rockspec
   +++ b/rockspec/apisix-master-0.rockspec
   @@ -41,14 +41,13 @@ dependencies = {
        "lua-resty-cookie = 0.1.0",
        "lua-resty-session = 2.24",
        "opentracing-openresty = 0.1",
   -    "lua-resty-radixtree = 1.5",
   +    "lua-resty-radixtree = 1.6-1",
        "lua-protobuf = 0.3.1",
        "lua-resty-openidc = 1.7.2-1",
        "luafilesystem = 1.7.0-2",
        "lua-tinyyaml = 0.1",
        "iresty-nginx-lua-prometheus = 0.20190917",
        "jsonschema = 0.4",
   -    "lua-resty-ipmatcher = 0.3",
    }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to