membphis commented on a change in pull request #1095: feature: Add wolf rbac
plugin
URL: https://github.com/apache/incubator-apisix/pull/1095#discussion_r373753953
##########
File path: lua/apisix/plugins/wolf-rbac.lua
##########
@@ -0,0 +1,380 @@
+
+local core = require("apisix.core")
+local ck = require("resty.cookie")
+local consumer = require("apisix.consumer")
+local json = require("apisix.core.json")
+local ngx_re = require("ngx.re")
+local cjson = require("cjson")
+local http = require("resty.http")
+local ipairs = ipairs
+local ngx = ngx
+local ngx_time = ngx.time
+local plugin_name = "wolf-rbac"
+
+
+local schema = {
+ type = "object",
+ properties = {
+ appid = {type = "string"},
+ server = { type = 'string'},
+ }
+}
+
+
+local _M = {
+ version = 0.1,
+ priority = 2555,
+ type = 'auth',
+ name = plugin_name,
+ schema = schema,
+}
+
+
+local create_consume_cache
+do
+ local consumer_ids = {}
+
+ function create_consume_cache(consumers)
+ core.table.clear(consumer_ids)
+
+ for _, consumer in ipairs(consumers.nodes) do
+ core.log.info("consumer node: ", core.json.delay_encode(consumer))
+ consumer_ids[consumer.auth_conf.appid] = consumer
+ end
+
+ return consumer_ids
+ end
+
+end -- do
+
+local token_version = 'V1'
+local function create_rbac_token(appid, wolf_token)
+ return token_version .. "#" .. appid .. "#" .. wolf_token
+end
+
+local function parse_rbac_token(rbac_token)
+ local res, err = ngx_re.split(rbac_token, "#", nil, nil, 3)
+ if not res then
+ return { err=err}
+ end
+
+ if res[1] ~= token_version then
+ return { err='invalid rbac token: version'}
+ end
+ local appid = res[2]
+ local wolf_token = res[3]
+
+ return {appid = appid, wolf_token = wolf_token}
+end
+
+local function new_headers()
+ local t = {}
+ local lt = {}
+ local _mt = {
+ __index = function(t, k)
+ return rawget(lt, string.lower(k))
+ end,
+ __newindex = function(t, k, v)
+ rawset(t, k, v)
+ rawset(lt, string.lower(k), v)
+ end,
+ }
+ return setmetatable(t, _mt)
+end
+
+-- timeout in ms
+local function http_req(method, uri, body, myheaders, timeout)
+ if myheaders == nil then myheaders = new_headers() end
+
+ local httpc = http.new()
+ if timeout then
+ httpc:set_timeout(timeout)
+ end
+
+ local params = {method = method, headers = myheaders, body=body,
ssl_verify=false}
+ local res, err = httpc:request_uri(uri, params)
+ if err then
+ core.log.error("FAIL REQUEST [
",core.json.delay_encode({method=method, uri=uri, body=body,
headers=myheaders}), " ] failed! res is nil, err:", err)
+ return nil, err
+ end
+
+ return res
+end
+
+local function http_get(uri, myheaders, timeout)
+ return http_req("GET", uri, nil, myheaders, timeout)
+end
+
+local function http_post(uri, body, myheaders, timeout)
+ return http_req("POST", uri, body, myheaders, timeout)
+end
+
+local function http_put(uri, body, myheaders, timeout)
+ return http_req("PUT", uri, body, myheaders, timeout)
+end
+
+function _M.check_schema(conf)
+ core.log.info("input conf: ", core.json.delay_encode(conf))
+
+ local ok, err = core.schema.check(schema, conf)
+ if not ok then
+ return false, err
+ end
+
+ if not conf.appid then
+ conf.appid = 'unset'
+ end
+ if not conf.server then
+ conf.server = 'http://127.0.0.1:10080'
+ end
+
+ return true
+end
+
+
+local function fetch_rbac_token()
+ local args = ngx.req.get_uri_args()
+ if args and args.rbac_token then
+ return args.rbac_token
+ end
+
+ local headers = ngx.req.get_headers()
+ if headers.Authorization then
+ return headers.Authorization
+ end
+ if headers['x-rbac-token'] then
+ return headers['x-rbac-token']
+ end
+ local cookie, err = ck:new()
+ if not cookie then
+ return nil, err
+ end
+ local val, err = cookie:get("x-rbac-token")
+ return val, err
+end
+
+local function loadjson(str)
+ local ok, jso = pcall(function() return cjson.decode(str) end)
+ if ok then
+ return jso
+ else
+ return nil, jso
+ end
+end
+
+local function check_url_permission(server, appid, action, resName, clientIP,
wolf_token)
+ local retry_max = 3
+ local errmsg = nil;
+ local userInfo = nil
+ local res = nil
+ local err = nil
+ local access_check_url = server .. "/wolf/rbac/access_check"
+ local headers = new_headers()
+ headers["x-rbac-token"] = wolf_token
+ headers["Content-Type"] = "application/json; charset=utf-8"
+ local args = { appID = appid, resName = resName, action = action,
clientIP=clientIP}
+ local url = access_check_url .. "?" .. ngx.encode_args(args)
+ local timeout = 1000 * 10
+
+ for i = 1, retry_max do
+ -- TODO: read apisix info.
+ res, err = http_get(url, headers, timeout)
+ if err then
+ errmsg = 'check permission failed!' .. tostring(err)
+ break
+ else
+ core.log.info("check permission request:", url, ", status:",
res.status, ",body:", core.json.delay_encode(res.body))
+ if res.status < 500 then
+ break
+ else
+ core.log.info("request [curl -v ", url, "] failed! status:",
res.status)
+ if i < retry_max then
+ ngx.sleep(100)
+ end
+ end
+ end
+ end
+
+ if err then
Review comment:
this is a bad code style, please take a look at this new style:
```lua
if err then
-- ...
end
if res.status ~= 200 and res.status ~= 401 then
return {status=500, err='request to wolf-server failed, status:' ..
tostring(res.status)}
end
-- ... other code
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
