moonming commented on issue #1106: request help: The configuration of the 
config.yaml file is a bit confusing.
URL: 
https://github.com/apache/incubator-apisix/issues/1106#issuecomment-582309937
 
 
   > According to the current classification, `real_ip_header` and 
`real_ip_from` should be placed in `nginx_config.http`.
   > 
   > I would prefer to use the following way.
   > 
   > ```yaml
   > nginx_config:                     # config for render the template to 
genarate nginx.conf
   >   error_log: "logs/error.log"
   >   error_log_level: "warn"         # warn,error
   >   event:
   >     worker_connections: 10620
   >   http:
   >      real_ip_header: "X-Real-IP" 
   >      real_ip_from:              
   >         - 127.0.0.1
   >         - 'unix:'
   >     access_log: "logs/access.log"
   >     keepalive_timeout: 60s         # timeout during which a keep-alive 
client connection will stay open on the server side.
   >     client_header_timeout: 60s     # timeout for reading client request 
header, then 408 (Request Time-out) error is returned to the client
   >     client_body_timeout: 60s       # timeout for reading client request 
body, then 408 (Request Time-out) error is returned to the client
   >     send_timeout: 10s              # timeout for transmitting a response 
to the client.then the connection is closed
   >   stream:
   >     proxy_protocol:                          true
   >     proxy_protocol_to_upstream:  true
   >     tcp:                        
   >       - 9100
   >       - 9101
   >     udp:                        
   >       - 9200
   >       - 9211
   > ```
   
   I don't think so. `nginx_config` is a hacky way, Apache APISIX should hide 
these Nginx configurations finally.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to