membphis commented on a change in pull request #1153: feature: support for
proxy caching plugin based on disk.
URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r386070744
##########
File path: lua/apisix/plugins/proxy-cache.lua
##########
@@ -186,22 +186,27 @@ function _M.header_filter(conf, ctx)
core.log.info("proxy-cache plugin header filter phase, conf: ",
core.json.delay_encode(conf))
local no_cache = "1"
+ local match_method, match_status = false, false
Review comment:
We can move this check logic into a single function, which will make the
code simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
