membphis commented on a change in pull request #1224: support base64 secret for
jwt auth
URL: https://github.com/apache/incubator-apisix/pull/1224#discussion_r392590494
##########
File path: lua/apisix/plugins/jwt-auth.lua
##########
@@ -114,6 +121,13 @@ local function fetch_jwt_token(ctx)
return val, err
end
+local function get_secret(conf)
+ if conf.base64_secret then
Review comment:
this style is better.
```lua
if ... then
end
...
return
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
