membphis commented on a change in pull request #1275: Add multiple etcd address
support.
URL: https://github.com/apache/incubator-apisix/pull/1275#discussion_r392738555
##########
File path: bin/apisix
##########
@@ -661,28 +661,32 @@ local function init_etcd(show_output)
end
local etcd_conf = yaml_conf.etcd
- local uri = etcd_conf.host .. "/v2/keys" .. (etcd_conf.prefix or "")
-
local timeout = etcd_conf.timeout or 3
+ local uri
+
+ for _, host in ipairs(yaml_conf.etcd.host) do
Review comment:
this is wrong.
If the user specifies multiple etcd addresses, these etcd instances should
belong to one cluster.
When we need to initialize etcd, as long as one of them is successfully
initialized, it is considered successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
