moonming commented on issue #1260: [WIP] Kafka Logger. URL: https://github.com/apache/incubator-apisix/pull/1260#issuecomment-600910280 > Hi @membphis @moonming this will be the basic kafka logger with one broker support. > > > > I think it's better to give the ability to define more brokers with object type ? > > > > broker = { > > "127.0.0.1" : "8080", > > "127.0.0.1" : "8090", > > } > > > > And below as the schema > > > > ` > > broker = {type = "object"}, > > timeout = { -- timeout in milliseconds > > type = "integer", minimum = 1, default= 2000 > > }, > > kafka_topic = {type = "string"}, > > async = { type = "boolean", default = false }, > > key = {type = "string"}, > > max_retry = {type = "integer", minimum = 0 , default = 3}, > > ` > > > > Also will fix the tests when schema is finalized LGTM
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
