membphis commented on a change in pull request #1349: Batch Processor: Fix for
rescheduling execution for max_retry_count is 0 and 1
URL: https://github.com/apache/incubator-apisix/pull/1349#discussion_r399272859
##########
File path: lua/apisix/utils/batch-processor.lua
##########
@@ -57,12 +57,12 @@ function execute_func(premature, batch_processor, batch)
return
end
- local ok, err = batch_processor.func(batch.entries)
+ local ok, err = batch_processor.func(batch.entries,
batch_processor.batch_max_size)
if not ok then
+ core.log.error(fmt("Batch Processor[%s] failed to process entries: ",
Review comment:
optimize: we should avoid to generate any new object , it will increase the
load on the Lua GC and make APISIX performance worse.
good style: `core.log.error("Batch Processor[", batch_processor.name, "]
failed to process entries: ", err)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
