moonming commented on a change in pull request #1370: enhance: plugin Zipkin
add service name and report local server IP
URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401345965
##########
File path: lua/apisix/plugins/zipkin.lua
##########
@@ -29,7 +29,17 @@ local schema = {
type = "object",
properties = {
endpoint = {type = "string"},
- sample_ratio = {type = "number", minimum = 0.00001, maximum = 1}
+ sample_ratio = {type = "number", minimum = 0.00001, maximum = 1},
+ service_name = {
+ type = "string",
+ description = "service name for zipkin reporter",
+ default = "APISIX",
+ },
+ server_addr = {
Review comment:
need add doc for `server_addr`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
