membphis commented on a change in pull request #1381: feature: response-rewrite
plugin rewrite binary data to client by base64
URL: https://github.com/apache/incubator-apisix/pull/1381#discussion_r401355081
##########
File path: apisix/plugins/response-rewrite.lua
##########
@@ -33,6 +33,11 @@ local schema = {
description = "new body for repsonse",
type = "string",
},
+ body_base64 = {
Review comment:
we can check if it is a valid `base64` value in `function
_M.check_schema(conf)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
