[GitHub] [incubator-apisix-dashboard] bzp2010 commented on a change in pull request #172: feature: improve project structure and fix some problem

[GitBox]

bzp2010 commented on a change in pull request #172: feature: improve project 
structure and fix some problem
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/172#discussion_r407011815
 
 

 ##########
 File path: config/config.ts
 ##########
 @@ -125,21 +125,26 @@ export default {
               path: '/ssl',
               icon: 'crown',
               routes: [
+                {
+                  path: '/ssl',
+                  redirect: '/ssl/list',
+                },
                 {
                   path: '/ssl/list',
                   name: 'list',
-                  component: './SSLModule/list',
 
 Review comment:
   We used to organize documents like this
   > 
![image](https://user-images.githubusercontent.com/8078418/79034442-77289980-7be8-11ea-8da8-8a0bee616234.png)
   
   I think it's more helpful to differentiate functional modules by changing it 
to the following form. (edit directory will be changed)
   > 
![image](https://user-images.githubusercontent.com/8078418/79034453-81e32e80-7be8-11ea-93d2-0270953aeed4.png)
   
   This requires discussion to determine the best option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services