moonming commented on a change in pull request #45:
URL: 
https://github.com/apache/incubator-apisix-docker/pull/45#discussion_r415067878



##########
File path: alpine/Dockerfile
##########
@@ -1,21 +1,39 @@
- FROM openresty/openresty:alpine-fat
+FROM node:10-alpine3.11 AS build-stage

Review comment:
       I think `openresty:alpine-fat` should be the build iamge, then copy 
OpenResty and APISIX files to `alpine:latest` image:
   
   ```
   FROM openresty/openresty:alpine-fat
   # install APISIX
   FROM alpine:latest  
   COPY OpenResty and APSIX dir
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to