shuaijinchao commented on a change in pull request #1914:
URL: https://github.com/apache/incubator-apisix/pull/1914#discussion_r461340753
##########
File path: apisix/schema_def.lua
##########
@@ -78,6 +78,11 @@ local health_checker = {
timeout = {type = "number", default = 1},
concurrency = {type = "integer", default = 10},
host = host_def,
+ port = {
+ type = "integer",
+ minimum = 1000,
Review comment:
I think that in general, ports below 1000 are open to the system, so
here is set to 1000.
##########
File path: apisix/schema_def.lua
##########
@@ -78,6 +78,11 @@ local health_checker = {
timeout = {type = "number", default = 1},
concurrency = {type = "integer", default = 10},
host = host_def,
+ port = {
+ type = "integer",
+ minimum = 1000,
Review comment:
OK, I will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
