membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466980620
########## File path: apisix/balancer/ewma.lua ########## @@ -0,0 +1,240 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to You under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. +-- + +local resty_lock = require("resty.lock") +local core = require("apisix.core") +local ngx = ngx +local ngx_shared = ngx.shared +local ngx_now = ngx.now +local tostring = tostring +local math = math +local pairs = pairs +local next = next +local tonumber = tonumber + +local _M = {} +local DECAY_TIME = 10 -- this value is in seconds +local LOCK_KEY = ":ewma_key" +local PICK_SET_SIZE = 2 +local ewma_lock, ewma_lock_err +local shm_ewma = ngx_shared.balancer_ewma +local shm_last_touched_at= ngx_shared.balancer_ewma_last_touched_at + + +local function lock(upstream) + local _, err = ewma_lock:lock(upstream .. LOCK_KEY) Review comment: I think we can remove all of the code about `lock`, they are useless. In `balance` phase, it not support `yield`, that means we can not call any `cosocket` and `ngx.sleep` function. The `resty-lock` depends on `ngx.sleep` when failed to set the lock flag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
