swayamraina commented on a change in pull request #1961:
URL: https://github.com/apache/apisix/pull/1961#discussion_r467494968



##########
File path: t/router/radixtree-sni.t
##########
@@ -313,6 +314,7 @@ sent http request: 62 bytes.
 received: HTTP/1.1 200 OK
 received: Content-Type: text/plain
 received: Connection: close
+received: Server: APISIX/(\d+)\.(\d+)\.(\d+)

Review comment:
       Should we update this to `([\d\.]+)(\d)$`
   `1.4.1fd` and `1.4.1.` also passes `([\d\.]+)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to