moonming commented on pull request #2026: URL: https://github.com/apache/apisix/pull/2026#issuecomment-670995043
Is this PR for tracing like skywalking or zipkin? YuanSheng Wang <[email protected]> 于 2020年8月9日周日 上午9:23写道： > *@membphis* commented on this pull request. > ------------------------------ > > In apisix/plugins/request-id.lua > <https://github.com/apache/apisix/pull/2026#discussion_r467522195>: > > > +-- Unless required by applicable law or agreed to in writing, software > +-- distributed under the License is distributed on an "AS IS" BASIS, > +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +-- See the License for the specific language governing permissions and > +-- limitations under the License. > +-- > +local core = require("apisix.core") > +local plugin_name = "request-id" > +local ngx = ngx > +local uuid = require("resty.jit-uuid") > + > +local schema = { > + type = "object", > + properties = { > + header_name = {type = "string", default = "X-Request-Id"}, > + include_in_response = {type = "boolean", default = false} > > I think the default value should be true. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/apache/apisix/pull/2026#pullrequestreview-463836184>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGJZBK2XE4FZ4FIEWX5GKFLR7X27PANCNFSM4PYSPUGA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
