Wcdaren commented on PR #2506: URL: https://github.com/apache/apisix-dashboard/pull/2506#issuecomment-1188517706
> > It's just that when I looked at the documentation I couldn't find the commit specification for the PR process (or maybe I was just careless and didn't notice it). For example, if a change is made during the PR process, should it be merged with the commit or should it not be merged and continue to follow the original commit specification, keeping the reason for the change > > Are you talking about modifying the code, please? Actually your PR will end up as a squash merge, so you can disregard the commit process. Thanks for the reply, as this is my first time to participate in open source, so some concepts will be rather unclear. What I'm confused about is how to write my commit when making code changes during the review process, for example <img width="901" alt="image" src="https://user-images.githubusercontent.com/25494875/179647586-4e148315-7659-43d0-a98f-fe280870c6a2.png";> As shown in the above diagram, is my reference compliant, or is the code change not required to be referenced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/25494875/179647586-4e148315-7659-43d0-a98f-fe280870c6a2.png"](https://user-images.githubusercontent.com/25494875/179647586-4e148315-7659-43d0-a98f-fe280870c6a2.png"){kind=link}