This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new a8069046f chore: remove stale todo at plugin redirect (#7487)
a8069046f is described below
commit a8069046fc15c9e7bc5c4b749ff6cd9730555a40
Author: kwanhur <[email protected]>
AuthorDate: Tue Jul 19 19:25:47 2022 +0800
chore: remove stale todo at plugin redirect (#7487)
- there're test cases at `t/plugin/redirect.t`
Signed-off-by: kwanhur <[email protected]>
---
apisix/plugins/redirect.lua | 2 --
1 file changed, 2 deletions(-)
diff --git a/apisix/plugins/redirect.lua b/apisix/plugins/redirect.lua
index fb2f75e68..5c45b7946 100644
--- a/apisix/plugins/redirect.lua
+++ b/apisix/plugins/redirect.lua
@@ -194,8 +194,6 @@ function _M.rewrite(conf, ctx)
local proxy_proto = core.request.header(ctx, "X-Forwarded-Proto")
local _scheme = proxy_proto or core.request.get_scheme(ctx)
if conf.http_to_https and _scheme == "http" then
- -- TODOļ¼ add test case
- -- PR: https://github.com/apache/apisix/pull/1958
if ret_port == nil or ret_port == 443 or ret_port <= 0 or ret_port >
65535 then
uri = "https://$host$request_uri";
else
