NMichas opened a new pull request, #316: URL: https://github.com/apache/apisix-helm-chart/pull/316
Purpose: Allow `fullnameOverride`s to work correctly to fully automate Helm deployments. Note: This is an updated PR, a lot less intrusive than the one suggested in https://github.com/apache/apisix-helm-chart/pull/292 (which I have now closed). - In APISIX admin: If the etcd subchart is configured to use a `fullnameOverride`, APISIX admin fails to start. This is due to the fact that etcd `fullnameOverride` is not taken into account in APISIX admin's init container nor configmap. This PR is backwards compatible in the sense that if users do not use a `fullnameOverride` for etcd, the chart behaves identically as before. - In APISIX Ingress Controller: `apisix.serviceName` and `apisix.serviceNamespace` must be explicitly set, thus not allowing users to fully automate a Helm install when using a custom `fullnameOverride` for APISIX admin which might have a different logic than the one currently used to construct the APISIX admin URL. This PR introduces a new value `apisix.serviceFullname`. When this value is set, it is overriding the logic of constructing the APISIX admin URL from `apisix.serviceName` and `apisix.serviceNamespace`. This PR is backwards compatible in the sense that if users do not use the newly introduced `apisix.serviceFullname` value, the chart behaves identically as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
