tzssangglass commented on code in PR #7590:
URL: https://github.com/apache/apisix/pull/7590#discussion_r935603150


##########
apisix/plugins/ldap-auth.lua:
##########
@@ -30,13 +30,12 @@ local schema = {
     title = "work with route or service object",
     properties = {
         base_dn = { type = "string" },
-        ldap_host = { type = "string" },
-        ldap_port = { type = "number" },
+        ldap_uri = { type = "string" },

Review Comment:
   Deleting these two options seems incompatible, can't we keep them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to