lingsamuel opened a new issue, #1226: URL: https://github.com/apache/apisix-ingress-controller/issues/1226
Currently our e2e case has a lot of duplicate code snippets, which will be harder to maintain as time goes on. A `Phase` function is a simple `func()` type function. Phase functions can be shared between different. For a typical case, we may have a "data preparation" phase, and a "validation" phase to verify that our controller is working properly. However, during the data preparation phase, we may need to support several different CRDs, such as ApisixRoute and Ingress. We simply copy and paste the entire case now. If we had the concept of phase, we could split the data preparation into a shared data preparation function and a specific CRD preparation function. In this way, we can share other code snippets without any copy and paste. This can reduce a lot of duplicate code and also greatly improve code readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
