FangSen9000 commented on PR #2502:
URL:
https://github.com/apache/apisix-dashboard/pull/2502#issuecomment-1207652983
These two assertions remove the name and content of the route, respectively.
I think it has three advantages :
1. It can prevent only deleting the key in the route attribute, but not
completely delete the route
2. It IS possible that THE TEST case on PAGE 2 will not BE FOUND IF there
ARE more test cases later on.
3. The search function automatically refreshes the page, which can prevent
timeout errors due to unrendered, and can make the test case more stable
---Original---
From: ***@***.***>
Date: Mon, Aug 8, 2022 09:54 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/apisix-dashboard] feat: Adding batch deletion
functionfor routing pages (PR #2502)
@Baoyuantop commented on this pull request.
In web/cypress/integration/route/batch-delete-route.spec.js:
> + cy.contains(data.test1).should('not.exist'); +
cy.contains(data.test0).should('not.exist'); +
cy.contains(data.test2).should('not.exist'); + // partial match +
cy.get(selector.nameSearchInput).clear().type(data.test2); +
cy.contains('Search').click(); +
cy.contains(data.test0).should('not.exist'); +
cy.contains(data.test1).should('not.exist'); +
cy.contains(data.test2).should('not.exist'); + // no match +
cy.get(selector.nameSearchInput).clear().type(data.testx); +
cy.contains('Search').click(); +
cy.contains(data.test0).should('not.exist'); +
cy.contains(data.test1).should('not.exist'); +
cy.contains(data.test2).should('not.exist'); + });
Why do we need to test these search functions? We only need to judge that
the data does not exist under
https://github.com/apache/apisix-dashboard/pull/2502/files#diff-6918beb43c48e71616c503a8dffc6d9cc572f37a69d1e27f792b71fda2e5416aR117.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
