tao12345666333 commented on code in PR #1200:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1200#discussion_r942763508
##########
pkg/config/config.go:
##########
@@ -79,6 +79,10 @@ type Config struct {
KeyFilePath string `json:"key_file"
yaml:"key_file"`
LogLevel string `json:"log_level"
yaml:"log_level"`
LogOutput string `json:"log_output"
yaml:"log_output"`
+ RotateOutputPath string
`json:"rotate_output_path" yaml:"rotate_output_path"`
+ RotationMaxSize int `json:"rotation_max_size"
yaml:"rotation_max_size"`
+ RotationMaxAge int `json:"rotation_max_age"
yaml:"rotation_max_age"`
+ RotationMaxBackups int
`json:"rotation_max_backups" yaml:"rotation_max_backups"`
Review Comment:
I suggest adding a LOG prefix to make it clear that it is related to log.
e.g. `LogRotationMaxSize`
##########
CHANGELOG.md:
##########
@@ -60,7 +60,7 @@ In next release(v1.5), custom resource's API version v2 will
be GA released. Ple
* fix: ingress update event handler not filter by watching namespaces
[#947](https://github.com/apache/apisix-ingress-controller/pull/)
Please try out the release binaries and report any issues at
-https://github.com/apache/apisix-ingress-controller/issues.
+<https://github.com/apache/apisix-ingress-controller/issues>.
Review Comment:
CHANGELOG is automatically generated, I recommend you to unmodify this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
