tokers commented on code in PR #7634:
URL: https://github.com/apache/apisix/pull/7634#discussion_r948892429


##########
docs/en/latest/plugins/openfunction.md:
##########
@@ -0,0 +1,139 @@
+---
+title: openfunction
+keywords:
+  - APISIX
+  - Plugin
+  - OpenFunction
+  - openfunction
+description: This document contains information about the CNCF OpenFunction 
Plugin.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Description
+
+The `openfunction` Plugin is used to integrate APISIX with [CNCF 
OpenFunction](https://openfunction.dev/) serverless platform.
+
+This Plugin can be configured on a Route and requests will be send to the 
configured OpenFunction API endpoint as the upstream.
+
+## Attributes
+
+| Name                        | Type    | Required | Default | Valid values | 
Description                                                                     
                           |
+| --------------------------- | ------- | -------- | ------- | ------------ | 
----------------------------------------------------------------------------------------------------------
 |
+| function_uri                | string  | True     |         |              | 
function uri. For example, `https://localhost:30858/default/function-sample`.   
                           |
+| ssl_verify                  | boolean | False    | true    |              | 
When set to `true` verifies the SSL certificate.                                
                           |
+| authorization               | object  | False    |         |              | 
Authorization credentials to access functions of OpenFunction.                  
                    |
+| authorization.service_token | string  | False    |         |              | 
The token format is 'xx:xx' which support basic auth for function entry points. 
                                     |
+| timeout                     | integer | False    | 3000ms  | [100, ...]ms | 
OpenFunction action and HTTP call timeout in ms.                                
                              |
+| keepalive                   | boolean | False    | true    |              | 
When set to `true` keeps the connection alive for reuse.                        
                           |
+| keepalive_timeout           | integer | False    | 60000ms | [1000,...]ms | 
Time is ms for connection to remain idle without closing.                       
                           |
+| keepalive_pool              | integer | False    | 5       | [1,...]      | 
Maximum number of requests that can be sent on this connection before closing 
it.                          |
+
+:::note
+
+The `timeout` attribute sets the time taken by the OpenFunction to execute, 
and the timeout for the HTTP client in APISIX. OpenFunction calls may take time 
to pull the runtime image and start the container. So, if the value is set too 
small, it may cause a large number of requests to fail.
+
+:::
+
+## Prerequisites
+
+Before configuring the plugin, you need to have OpenFunction running.
+Installation of OpenFunction requires a certain version Kubernetes cluster.
+For details, please refer to 
[Installation](https://openfunction.dev/docs/getting-started/installation/).

Review Comment:
   Add a sub title:
   
   ```
   ### Install OpenFunction via Helm Chart
   ```



##########
docs/en/latest/plugins/openfunction.md:
##########
@@ -0,0 +1,139 @@
+---
+title: openfunction
+keywords:
+  - APISIX
+  - Plugin
+  - OpenFunction
+  - openfunction
+description: This document contains information about the CNCF OpenFunction 
Plugin.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Description
+
+The `openfunction` Plugin is used to integrate APISIX with [CNCF 
OpenFunction](https://openfunction.dev/) serverless platform.
+
+This Plugin can be configured on a Route and requests will be send to the 
configured OpenFunction API endpoint as the upstream.
+
+## Attributes
+
+| Name                        | Type    | Required | Default | Valid values | 
Description                                                                     
                           |
+| --------------------------- | ------- | -------- | ------- | ------------ | 
----------------------------------------------------------------------------------------------------------
 |
+| function_uri                | string  | True     |         |              | 
function uri. For example, `https://localhost:30858/default/function-sample`.   
                           |
+| ssl_verify                  | boolean | False    | true    |              | 
When set to `true` verifies the SSL certificate.                                
                           |
+| authorization               | object  | False    |         |              | 
Authorization credentials to access functions of OpenFunction.                  
                    |
+| authorization.service_token | string  | False    |         |              | 
The token format is 'xx:xx' which support basic auth for function entry points. 
                                     |
+| timeout                     | integer | False    | 3000ms  | [100, ...]ms | 
OpenFunction action and HTTP call timeout in ms.                                
                              |
+| keepalive                   | boolean | False    | true    |              | 
When set to `true` keeps the connection alive for reuse.                        
                           |
+| keepalive_timeout           | integer | False    | 60000ms | [1000,...]ms | 
Time is ms for connection to remain idle without closing.                       
                           |
+| keepalive_pool              | integer | False    | 5       | [1,...]      | 
Maximum number of requests that can be sent on this connection before closing 
it.                          |
+
+:::note
+
+The `timeout` attribute sets the time taken by the OpenFunction to execute, 
and the timeout for the HTTP client in APISIX. OpenFunction calls may take time 
to pull the runtime image and start the container. So, if the value is set too 
small, it may cause a large number of requests to fail.
+
+:::
+
+## Prerequisites
+
+Before configuring the plugin, you need to have OpenFunction running.
+Installation of OpenFunction requires a certain version Kubernetes cluster.
+For details, please refer to 
[Installation](https://openfunction.dev/docs/getting-started/installation/).
+The example below shows OpenFunction installed in Helm:
+
+```shell
+# add the OpenFunction chart repository
+helm repo add openfunction https://openfunction.github.io/charts/
+helm repo update
+
+#install the OpenFunction chart
+kubectl create namespace openfunction
+helm install openfunction openfunction/openfunction -n openfunction
+```
+
+You can then verify if OpenFunction is ready:
+
+```shell
+kubectl get pods --namespace openfunction
+```
+

Review Comment:
   Add a sub title:
   
   ```
   ### Push a Function
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to