[GitHub] [apisix] spacewander commented on a diff in pull request #7747: fix:When the token in the configuration file is a numeric type, the verification fails due to the inconsistency of the types. The reasons are as follows: the requested type (req_token) = string, the configured type (token) = number

[GitBox]

spacewander commented on code in PR #7747:
URL: https://github.com/apache/apisix/pull/7747#discussion_r950840865


##########
apisix/admin/init.lua:
##########
@@ -76,7 +76,7 @@ local function check_token(ctx)
 
     local admin
     for i, row in ipairs(local_conf.apisix.admin_key) do
-        if req_token == row.key then
+        if req_token == tostring(row.key) then

Review Comment:
   We can wrap the key with `""` to ensure key is a string?
   Like `"edd1c9f034335f136f87ad84b625c8f1"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org