tzssangglass commented on code in PR #7749: URL: https://github.com/apache/apisix/pull/7749#discussion_r950955310
########## docs/en/latest/plugins/log-rotate.md: ########## @@ -39,6 +39,7 @@ You can configure how often the logs are rotated and how many logs to keep. When |--------------------|---------|----------|---------|------------------------------------------------------------------------------------------------| | interval | integer | True | 60 * 60 | Time in seconds specifying how often to rotate the logs. | | max_kept | integer | True | 24 * 7 | Maximum number of historical logs to keep. If this number is exceeded, older logs are deleted. | +| max_size | integer | False | -1 | Max size(Bytes) of log files to be rotated, size check would be skipped with a value less than 0. | Review Comment: Should we clarify that rotating the logs when time is up or when the log size reaches max_size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
