qihaiyan commented on code in PR #7749: URL: https://github.com/apache/apisix/pull/7749#discussion_r953458332
########## apisix/plugins/log-rotate.lua: ########## @@ -49,6 +50,7 @@ local default_logs local enable_compression = false local DEFAULT_ACCESS_LOG_FILENAME = "access.log" local DEFAULT_ERROR_LOG_FILENAME = "error.log" +local SIGUSR1 = 10 Review Comment: Because signal.signum may return nil, so we give it a default value when it's null, this function's doc says: ` Maps the signal name specified to the system-specific signal number. Returns nil if the signal name is not known ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
