kingluo commented on issue #7804:
URL: https://github.com/apache/apisix/issues/7804#issuecomment-1233869701

   @tzssangglass If the rate is configurated as 20000 reqs/sec, and the real 
rate is not faster than this rate, so the test should not fail. I don't think 
it's a defect of leaky bucket algorithm.
   
   I agree with @monkeyDluffy6017. It happens when the duration between two 
consecutive requests is small or even 0 (rememeber that the time resolution is 
in milliseconds.), where the calculated rate is higher than the real one.
   
   @wyfaq IMO, I think you should configure `burst` to be equal to `rate` at 
least.
   
   BTW, in Chinese doc, the descriptioin about `burst` is wrong, the burst is 
not an incremental value but an absolute value: 
https://apisix.apache.org/zh/docs/apisix/plugins/limit-req/.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to