xiangtianyu commented on code in PR #1311:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1311#discussion_r960405153
##########
pkg/providers/ingress/ingress.go:
##########
@@ -428,7 +428,20 @@ func (c *ingressController) ResourceSync() {
if !c.namespaceProvider.IsWatchingNamespace(key) {
continue
}
+
ing := kube.MustNewIngress(obj)
+ valid := c.isIngressEffective(ing)
+ if valid {
+ log.Debugw("ingress add event arrived",
+ zap.Any("object", obj),
+ )
+ } else {
+ log.Debugw("ignore noneffective ingress add event",
+ zap.Any("object", obj),
+ )
+ return
+ }
Review Comment:
Are you means to summarize these "valid judge" logic to common codes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
