FangSen9000 commented on PR #2581: URL: https://github.com/apache/apisix-dashboard/pull/2581#issuecomment-1240299363
@guoqqqi, you said before that you would consider merging only if E2E is completely correct, but recently you should have found that the current test is problematic, but it is completely correct and needs to be fixed. Among them, five test cases are problematic, and they are difficult to pass. (this is not my problem, but the new E2E test case error that occurred after ten days ago) are: 1. _Create delete in drawer plugin.cy.js_ 2. _Upstream create_ and_ edit_ upstream_ with_ no_ Nodes.cy.js_ 3. _Service-edit-service-with-upstream.cy.js_ (this mainly occurs in the cloud) 4. _Plugin-schema.cy.js_. Fortunately, I solved the first and second. The fourth one is the most serious one. It can not pass at all. It is a loop test. There is a problem with a judgment in the middle. There is no problem in the test logic, but somehow the judgment fails and the loop jumps out midway. You can see this https://github.com/apache/apisix-dashboard/pull/2612/checks. If there is no change, there will be 100% errors. I tried to spend three days, but I didn't find the root cause. (the third and fourth should find a more professional tester to have a look. The pass rate of the third is only 10% in a certain environment. The elements are either separated, lost or missing, and only appear in the cloud. It is normal locally, as shown in the video below:) https://user-images.githubusercontent.com/72308243/189047162-0da14fc5-a3fa-47ee-8ab4-821647624c8f.mp4 > @Baoyuantop @bzp2010 If you have time, you can give some suggestions. And, If anyone can try to fix the test cases of 3 and 4, you can find them. Many people have these two problems in PR. To sum up, the **effect** of this PR is: add tip and preset model for plugin editor, improve E2E stability All my work on improving test stability can be seen in this pr. This should reduce the error rate of the test. For the explanation of model, please see the text at the top of this pr. It helps users to use the plug-in by presetting the plug-in template. There is a video. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
