tokers commented on code in PR #345:
URL: https://github.com/apache/apisix-helm-chart/pull/345#discussion_r970206913
##########
charts/apisix/templates/ingress.yaml:
##########
@@ -34,6 +34,9 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
+ {{- if .Values.gateway.ingress.className }}
+ ingressClassName: {{ .Values.gateway.ingress.className }}
Review Comment:
This field was introduced since k8s 1.18, but the ingress resource for
apisix is also compatible with older ingress version (extensions). So only add
this field only if the k8s version is new enough.
We also need to consider removing the support for older ingress versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
