monkeyDluffy6017 commented on code in PR #7946:
URL: https://github.com/apache/apisix/pull/7946#discussion_r974863364


##########
t/tars/discovery/tars.t:
##########
@@ -41,8 +41,8 @@ discovery:
       database: db_tars
       user: root
       password: tars2022
-    full_fetch_interval: 3
-    incremental_fetch_interval: 1
+    full_fetch_interval: 90

Review Comment:
   ```   
    -- fill the default value by the schema
       schema.validate(default_conf)
   ```
   We didn't handle the result of schema validation before, that's why your 
solution work, we need to throw error now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to