soulbird commented on code in PR #7947:
URL: https://github.com/apache/apisix/pull/7947#discussion_r977704185


##########
t/plugin/ext-plugin/extra-info.t:
##########
@@ -181,3 +182,156 @@ GET /hello
 --- error_code: 503
 --- error_log
 failed to receive RPC_HTTP_REQ_CALL: closed
+
+
+
+=== TEST 5: ask response body (not exist)

Review Comment:
   It doesn't make sense to add a test with an empty response body in the 
`ext-plugin-pre-req` plugin. I guess you want me to add this test case in the 
`ext-plugin-post-resp` plugin.
   However, an empty response body usually occurs when the upstream returns a 
304 status code or the request method is HEAD, which needs to be handled 
separately in subsequent PRs. I have added `TODO`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to