tao12345666333 commented on code in PR #1051:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1051#discussion_r978240972
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -521,6 +521,8 @@ spec:
match:
type: object
properties:
+ host:
+ type: string
Review Comment:
please move this field to v2 api version section
##########
pkg/kube/apisix/apis/config/v2beta3/types.go:
##########
@@ -217,7 +217,8 @@ type ApisixRouteStream struct {
type ApisixRouteStreamMatch struct {
// IngressPort represents the port listening on the Ingress proxy
server.
// It should be pre-defined as APISIX doesn't support dynamic listening.
- IngressPort int32 `json:"ingressPort" yaml:"ingressPort"`
+ IngressPort int32 `json:"ingressPort" yaml:"ingressPort"`
+ Host string `json:"host,omitempty" yaml:"host,omitempty"`
Review Comment:
move this to v2/types.go file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
