FangSen9000 commented on code in PR #2581:
URL: https://github.com/apache/apisix-dashboard/pull/2581#discussion_r963474405
##########
web/cypress/e2e/rest/service-edit-service-with-upstream.cy.js:
##########
@@ -94,7 +93,6 @@ context('Edit Service with Upstream', () => {
force: true,
})
.should('value', data.ip1);
- cy.get(selector.input).should('be.disabled');
Review Comment:
1. If the IP disappears, the following Test Cy will remind us that this is
**unnecessary**. I feel that I just want to appear professional, so I wrote
this.
2. Clicking on a disabled input box is strange. It's better to use contain
or something else. According to attempts, this writing will lead to element
conflicts in an assertion. This place often occurs, and the element is
separated from the DOM, which is the reason.
##########
web/cypress/e2e/rest/service-edit-service-with-upstream.cy.js:
##########
@@ -73,7 +73,6 @@ context('Edit Service with Upstream', () => {
cy.get(selector.description).type(data.description);
cy.get(selector.upstreamSelector).click();
cy.contains(data.upstreamName).click();
- cy.get(selector.input).should('be.disabled');
Review Comment:
If you don't click next, some will be banned and some will not. Its
positioning of elements is not accurate. It may refer to all input boxes, but
there are forbidden and good input boxes. No matter whether it is '.not ' or
'.be', it will make mistakes. If it refers to the box just entered, there is
something wrong with its writing. It's better to delete it.
**In a word**, name has just been written. It will not be abandoned until I
click ‘next’.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
