soulbird commented on code in PR #8050:
URL: https://github.com/apache/apisix/pull/8050#discussion_r991740030
##########
ci/pod/docker-compose.plugin.yml:
##########
@@ -104,17 +104,22 @@ services:
kafka-server2:
image: bitnami/kafka:2.8.1
env_file:
- - ci/pod/kafka/kafka-server/env/common.env
+ - ci/pod/kafka/kafka-server/env/common2.env
environment:
KAFKA_CFG_ZOOKEEPER_CONNECT: zookeeper-server2:2181
restart: unless-stopped
ports:
- "19092:9092"
+ - "19094:9094"
depends_on:
- zookeeper-server1
- zookeeper-server2
networks:
kafka_net:
+ volumes:
+ -
./ci/pod/kafka/kafka-server/kafka_jaas.conf:/opt/bitnami/kafka/config/kafka_jaas.conf:ro
+ -
./ci/pod/kafka/kafka-server/selfsigned.jks:/opt/bitnami/kafka/config/certs/kafka.keystore.jks:ro
+ -
./ci/pod/kafka/kafka-server/selfsigned.jks:/opt/bitnami/kafka/config/certs/kafka.truststore.jks:ro
Review Comment:
The `selfsigned.jks` file is only generated when the `last` test is
executed, look:
https://github.com/apache/apisix/blob/master/.github/workflows/build.yml#L117-L120,
and should not exist when the `plugin` test is executed. Why can CI still
pass, very puzzled.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
